Catch std::logic_error and std::invalid_argument by const ref

wravery · wravery · commit a82649e5fd01 · 2020-12-30T20:30:09.000-08:00
diff --git a/test/TodayTests.cpp b/test/TodayTests.cpp
@@ -714,7 +714,7 @@ TEST_F(TodayServiceCase, DeliverNextAppointmentChangeNoSubscriptionObject)
 	{
 		service->deliver("nextAppointmentChange", nullptr);
 	}
-	catch (std::invalid_argument& ex)
+	catch (const std::invalid_argument& ex)
 	{
 		EXPECT_TRUE(ex.what() == "Missing subscriptionObject"sv) << "exception should match";
 		exception = true;
@@ -732,7 +732,7 @@ TEST_F(TodayServiceCase, DeliverNextAppointmentChangeNoSubscriptionSupport)
 	{
 		service->deliver("nextAppointmentChange", nullptr);
 	}
-	catch (std::logic_error& ex)
+	catch (const std::logic_error& ex)
 	{
 		EXPECT_TRUE(ex.what() == "Subscriptions not supported"sv) << "exception should match";
 		exception = true;

Original file line number	Diff line number	Diff line change
`@@ -714,7 +714,7 @@ TEST_F(TodayServiceCase, DeliverNextAppointmentChangeNoSubscriptionObject)`
`714`	`714`	`{`
`715`	`715`	`service->deliver("nextAppointmentChange", nullptr);`
`716`	`716`	`}`
`717`		`- catch (std::invalid_argument& ex)`
	`717`	`+ catch (const std::invalid_argument& ex)`
`718`	`718`	`{`
`719`	`719`	`EXPECT_TRUE(ex.what() == "Missing subscriptionObject"sv) << "exception should match";`
`720`	`720`	`exception = true;`
`@@ -732,7 +732,7 @@ TEST_F(TodayServiceCase, DeliverNextAppointmentChangeNoSubscriptionSupport)`
`732`	`732`	`{`
`733`	`733`	`service->deliver("nextAppointmentChange", nullptr);`
`734`	`734`	`}`
`735`		`- catch (std::logic_error& ex)`
	`735`	`+ catch (const std::logic_error& ex)`
`736`	`736`	`{`
`737`	`737`	`EXPECT_TRUE(ex.what() == "Subscriptions not supported"sv) << "exception should match";`
`738`	`738`	`exception = true;`