Fix implicit-cast-to-bool bug for resolve__typename

wravery · wravery · commit b8d3e59a33d2 · 2019-01-26T14:45:05.000-08:00
diff --git a/SchemaGenerator.cpp b/SchemaGenerator.cpp
@@ -2000,7 +2000,7 @@ std::future<response::Value> )cpp" << objectType.type
 {
 	std::promise<response::Value> promise;
 
-	promise.set_value(response::Value(")cpp" << objectType.type << R"cpp("));
+	promise.set_value(response::Value(std::string(")cpp" << objectType.type << R"cpp(")));
 
 	return promise.get_future();
 }
diff --git a/samples/IntrospectionSchema.cpp b/samples/IntrospectionSchema.cpp
@@ -195,7 +195,7 @@ std::future<response::Value> __Schema::resolve__typename(service::ResolverParams
 {
 	std::promise<response::Value> promise;
 
-	promise.set_value(response::Value("__Schema"));
+	promise.set_value(response::Value(std::string("__Schema")));
 
 	return promise.get_future();
 }
@@ -315,7 +315,7 @@ std::future<response::Value> __Type::resolve__typename(service::ResolverParams&&
 {
 	std::promise<response::Value> promise;
 
-	promise.set_value(response::Value("__Type"));
+	promise.set_value(response::Value(std::string("__Type")));
 
 	return promise.get_future();
 }
@@ -381,7 +381,7 @@ std::future<response::Value> __Field::resolve__typename(service::ResolverParams&
 {
 	std::promise<response::Value> promise;
 
-	promise.set_value(response::Value("__Field"));
+	promise.set_value(response::Value(std::string("__Field")));
 
 	return promise.get_future();
 }
@@ -431,7 +431,7 @@ std::future<response::Value> __InputValue::resolve__typename(service::ResolverPa
 {
 	std::promise<response::Value> promise;
 
-	promise.set_value(response::Value("__InputValue"));
+	promise.set_value(response::Value(std::string("__InputValue")));
 
 	return promise.get_future();
 }
@@ -481,7 +481,7 @@ std::future<response::Value> __EnumValue::resolve__typename(service::ResolverPar
 {
 	std::promise<response::Value> promise;
 
-	promise.set_value(response::Value("__EnumValue"));
+	promise.set_value(response::Value(std::string("__EnumValue")));
 
 	return promise.get_future();
 }
@@ -531,7 +531,7 @@ std::future<response::Value> __Directive::resolve__typename(service::ResolverPar
 {
 	std::promise<response::Value> promise;
 
-	promise.set_value(response::Value("__Directive"));
+	promise.set_value(response::Value(std::string("__Directive")));
 
 	return promise.get_future();
 }
diff --git a/samples/TodaySchema.cpp b/samples/TodaySchema.cpp
@@ -212,7 +212,7 @@ std::future<response::Value> Query::resolve__typename(service::ResolverParams&&)
 {
 	std::promise<response::Value> promise;
 
-	promise.set_value(response::Value("Query"));
+	promise.set_value(response::Value(std::string("Query")));
 
 	return promise.get_future();
 }
@@ -265,7 +265,7 @@ std::future<response::Value> PageInfo::resolve__typename(service::ResolverParams
 {
 	std::promise<response::Value> promise;
 
-	promise.set_value(response::Value("PageInfo"));
+	promise.set_value(response::Value(std::string("PageInfo")));
 
 	return promise.get_future();
 }
@@ -299,7 +299,7 @@ std::future<response::Value> AppointmentEdge::resolve__typename(service::Resolve
 {
 	std::promise<response::Value> promise;
 
-	promise.set_value(response::Value("AppointmentEdge"));
+	promise.set_value(response::Value(std::string("AppointmentEdge")));
 
 	return promise.get_future();
 }
@@ -333,7 +333,7 @@ std::future<response::Value> AppointmentConnection::resolve__typename(service::R
 {
 	std::promise<response::Value> promise;
 
-	promise.set_value(response::Value("AppointmentConnection"));
+	promise.set_value(response::Value(std::string("AppointmentConnection")));
 
 	return promise.get_future();
 }
@@ -367,7 +367,7 @@ std::future<response::Value> TaskEdge::resolve__typename(service::ResolverParams
 {
 	std::promise<response::Value> promise;
 
-	promise.set_value(response::Value("TaskEdge"));
+	promise.set_value(response::Value(std::string("TaskEdge")));
 
 	return promise.get_future();
 }
@@ -401,7 +401,7 @@ std::future<response::Value> TaskConnection::resolve__typename(service::Resolver
 {
 	std::promise<response::Value> promise;
 
-	promise.set_value(response::Value("TaskConnection"));
+	promise.set_value(response::Value(std::string("TaskConnection")));
 
 	return promise.get_future();
 }
@@ -435,7 +435,7 @@ std::future<response::Value> FolderEdge::resolve__typename(service::ResolverPara
 {
 	std::promise<response::Value> promise;
 
-	promise.set_value(response::Value("FolderEdge"));
+	promise.set_value(response::Value(std::string("FolderEdge")));
 
 	return promise.get_future();
 }
@@ -469,7 +469,7 @@ std::future<response::Value> FolderConnection::resolve__typename(service::Resolv
 {
 	std::promise<response::Value> promise;
 
-	promise.set_value(response::Value("FolderConnection"));
+	promise.set_value(response::Value(std::string("FolderConnection")));
 
 	return promise.get_future();
 }
@@ -503,7 +503,7 @@ std::future<response::Value> CompleteTaskPayload::resolve__typename(service::Res
 {
 	std::promise<response::Value> promise;
 
-	promise.set_value(response::Value("CompleteTaskPayload"));
+	promise.set_value(response::Value(std::string("CompleteTaskPayload")));
 
 	return promise.get_future();
 }
@@ -530,7 +530,7 @@ std::future<response::Value> Mutation::resolve__typename(service::ResolverParams
 {
 	std::promise<response::Value> promise;
 
-	promise.set_value(response::Value("Mutation"));
+	promise.set_value(response::Value(std::string("Mutation")));
 
 	return promise.get_future();
 }
@@ -565,7 +565,7 @@ std::future<response::Value> Subscription::resolve__typename(service::ResolverPa
 {
 	std::promise<response::Value> promise;
 
-	promise.set_value(response::Value("Subscription"));
+	promise.set_value(response::Value(std::string("Subscription")));
 
 	return promise.get_future();
 }
@@ -616,7 +616,7 @@ std::future<response::Value> Appointment::resolve__typename(service::ResolverPar
 {
 	std::promise<response::Value> promise;
 
-	promise.set_value(response::Value("Appointment"));
+	promise.set_value(response::Value(std::string("Appointment")));
 
 	return promise.get_future();
 }
@@ -659,7 +659,7 @@ std::future<response::Value> Task::resolve__typename(service::ResolverParams&&)
 {
 	std::promise<response::Value> promise;
 
-	promise.set_value(response::Value("Task"));
+	promise.set_value(response::Value(std::string("Task")));
 
 	return promise.get_future();
 }
@@ -702,7 +702,7 @@ std::future<response::Value> Folder::resolve__typename(service::ResolverParams&&
 {
 	std::promise<response::Value> promise;
 
-	promise.set_value(response::Value("Folder"));
+	promise.set_value(response::Value(std::string("Folder")));
 
 	return promise.get_future();
 }
@@ -736,7 +736,7 @@ std::future<response::Value> NestedType::resolve__typename(service::ResolverPara
 {
 	std::promise<response::Value> promise;
 
-	promise.set_value(response::Value("NestedType"));
+	promise.set_value(response::Value(std::string("NestedType")));
 
 	return promise.get_future();
 }

Original file line number	Diff line number	Diff line change
`@@ -2000,7 +2000,7 @@ std::future<response::Value> )cpp" << objectType.type`
`2000`	`2000`	`{`
`2001`	`2001`	`std::promise<response::Value> promise;`
`2002`	`2002`
`2003`		`- promise.set_value(response::Value(")cpp" << objectType.type << R"cpp("));`
	`2003`	`+ promise.set_value(response::Value(std::string(")cpp" << objectType.type << R"cpp(")));`
`2004`	`2004`
`2005`	`2005`	`return promise.get_future();`
`2006`	`2006`	`}`
Original file line number	Diff line number	Diff line change
`@@ -195,7 +195,7 @@ std::future<response::Value> __Schema::resolve__typename(service::ResolverParams`
`195`	`195`	`{`
`196`	`196`	`std::promise<response::Value> promise;`
`197`	`197`
`198`		`- promise.set_value(response::Value("__Schema"));`
	`198`	`+ promise.set_value(response::Value(std::string("__Schema")));`
`199`	`199`
`200`	`200`	`return promise.get_future();`
`201`	`201`	`}`
`@@ -315,7 +315,7 @@ std::future<response::Value> __Type::resolve__typename(service::ResolverParams&&`
`315`	`315`	`{`
`316`	`316`	`std::promise<response::Value> promise;`
`317`	`317`
`318`		`- promise.set_value(response::Value("__Type"));`
	`318`	`+ promise.set_value(response::Value(std::string("__Type")));`
`319`	`319`
`320`	`320`	`return promise.get_future();`
`321`	`321`	`}`
`@@ -381,7 +381,7 @@ std::future<response::Value> __Field::resolve__typename(service::ResolverParams&`
`381`	`381`	`{`
`382`	`382`	`std::promise<response::Value> promise;`
`383`	`383`
`384`		`- promise.set_value(response::Value("__Field"));`
	`384`	`+ promise.set_value(response::Value(std::string("__Field")));`
`385`	`385`
`386`	`386`	`return promise.get_future();`
`387`	`387`	`}`
`@@ -431,7 +431,7 @@ std::future<response::Value> __InputValue::resolve__typename(service::ResolverPa`
`431`	`431`	`{`
`432`	`432`	`std::promise<response::Value> promise;`
`433`	`433`
`434`		`- promise.set_value(response::Value("__InputValue"));`
	`434`	`+ promise.set_value(response::Value(std::string("__InputValue")));`
`435`	`435`
`436`	`436`	`return promise.get_future();`
`437`	`437`	`}`
`@@ -481,7 +481,7 @@ std::future<response::Value> __EnumValue::resolve__typename(service::ResolverPar`
`481`	`481`	`{`
`482`	`482`	`std::promise<response::Value> promise;`
`483`	`483`
`484`		`- promise.set_value(response::Value("__EnumValue"));`
	`484`	`+ promise.set_value(response::Value(std::string("__EnumValue")));`
`485`	`485`
`486`	`486`	`return promise.get_future();`
`487`	`487`	`}`
`@@ -531,7 +531,7 @@ std::future<response::Value> __Directive::resolve__typename(service::ResolverPar`
`531`	`531`	`{`
`532`	`532`	`std::promise<response::Value> promise;`
`533`	`533`
`534`		`- promise.set_value(response::Value("__Directive"));`
	`534`	`+ promise.set_value(response::Value(std::string("__Directive")));`
`535`	`535`
`536`	`536`	`return promise.get_future();`
`537`	`537`	`}`
Original file line number	Diff line number	Diff line change
`@@ -212,7 +212,7 @@ std::future<response::Value> Query::resolve__typename(service::ResolverParams&&)`
`212`	`212`	`{`
`213`	`213`	`std::promise<response::Value> promise;`
`214`	`214`
`215`		`- promise.set_value(response::Value("Query"));`
	`215`	`+ promise.set_value(response::Value(std::string("Query")));`
`216`	`216`
`217`	`217`	`return promise.get_future();`
`218`	`218`	`}`
`@@ -265,7 +265,7 @@ std::future<response::Value> PageInfo::resolve__typename(service::ResolverParams`
`265`	`265`	`{`
`266`	`266`	`std::promise<response::Value> promise;`
`267`	`267`
`268`		`- promise.set_value(response::Value("PageInfo"));`
	`268`	`+ promise.set_value(response::Value(std::string("PageInfo")));`
`269`	`269`
`270`	`270`	`return promise.get_future();`
`271`	`271`	`}`
`@@ -299,7 +299,7 @@ std::future<response::Value> AppointmentEdge::resolve__typename(service::Resolve`
`299`	`299`	`{`
`300`	`300`	`std::promise<response::Value> promise;`
`301`	`301`
`302`		`- promise.set_value(response::Value("AppointmentEdge"));`
	`302`	`+ promise.set_value(response::Value(std::string("AppointmentEdge")));`
`303`	`303`
`304`	`304`	`return promise.get_future();`
`305`	`305`	`}`
`@@ -333,7 +333,7 @@ std::future<response::Value> AppointmentConnection::resolve__typename(service::R`
`333`	`333`	`{`
`334`	`334`	`std::promise<response::Value> promise;`
`335`	`335`
`336`		`- promise.set_value(response::Value("AppointmentConnection"));`
	`336`	`+ promise.set_value(response::Value(std::string("AppointmentConnection")));`
`337`	`337`
`338`	`338`	`return promise.get_future();`
`339`	`339`	`}`
`@@ -367,7 +367,7 @@ std::future<response::Value> TaskEdge::resolve__typename(service::ResolverParams`
`367`	`367`	`{`
`368`	`368`	`std::promise<response::Value> promise;`
`369`	`369`
`370`		`- promise.set_value(response::Value("TaskEdge"));`
	`370`	`+ promise.set_value(response::Value(std::string("TaskEdge")));`
`371`	`371`
`372`	`372`	`return promise.get_future();`
`373`	`373`	`}`
`@@ -401,7 +401,7 @@ std::future<response::Value> TaskConnection::resolve__typename(service::Resolver`
`401`	`401`	`{`
`402`	`402`	`std::promise<response::Value> promise;`
`403`	`403`
`404`		`- promise.set_value(response::Value("TaskConnection"));`
	`404`	`+ promise.set_value(response::Value(std::string("TaskConnection")));`
`405`	`405`
`406`	`406`	`return promise.get_future();`
`407`	`407`	`}`
`@@ -435,7 +435,7 @@ std::future<response::Value> FolderEdge::resolve__typename(service::ResolverPara`
`435`	`435`	`{`
`436`	`436`	`std::promise<response::Value> promise;`
`437`	`437`
`438`		`- promise.set_value(response::Value("FolderEdge"));`
	`438`	`+ promise.set_value(response::Value(std::string("FolderEdge")));`
`439`	`439`
`440`	`440`	`return promise.get_future();`
`441`	`441`	`}`
`@@ -469,7 +469,7 @@ std::future<response::Value> FolderConnection::resolve__typename(service::Resolv`
`469`	`469`	`{`
`470`	`470`	`std::promise<response::Value> promise;`
`471`	`471`
`472`		`- promise.set_value(response::Value("FolderConnection"));`
	`472`	`+ promise.set_value(response::Value(std::string("FolderConnection")));`
`473`	`473`
`474`	`474`	`return promise.get_future();`
`475`	`475`	`}`
`@@ -503,7 +503,7 @@ std::future<response::Value> CompleteTaskPayload::resolve__typename(service::Res`
`503`	`503`	`{`
`504`	`504`	`std::promise<response::Value> promise;`
`505`	`505`
`506`		`- promise.set_value(response::Value("CompleteTaskPayload"));`
	`506`	`+ promise.set_value(response::Value(std::string("CompleteTaskPayload")));`
`507`	`507`
`508`	`508`	`return promise.get_future();`
`509`	`509`	`}`
`@@ -530,7 +530,7 @@ std::future<response::Value> Mutation::resolve__typename(service::ResolverParams`
`530`	`530`	`{`
`531`	`531`	`std::promise<response::Value> promise;`
`532`	`532`
`533`		`- promise.set_value(response::Value("Mutation"));`
	`533`	`+ promise.set_value(response::Value(std::string("Mutation")));`
`534`	`534`
`535`	`535`	`return promise.get_future();`
`536`	`536`	`}`
`@@ -565,7 +565,7 @@ std::future<response::Value> Subscription::resolve__typename(service::ResolverPa`
`565`	`565`	`{`
`566`	`566`	`std::promise<response::Value> promise;`
`567`	`567`
`568`		`- promise.set_value(response::Value("Subscription"));`
	`568`	`+ promise.set_value(response::Value(std::string("Subscription")));`
`569`	`569`
`570`	`570`	`return promise.get_future();`
`571`	`571`	`}`
`@@ -616,7 +616,7 @@ std::future<response::Value> Appointment::resolve__typename(service::ResolverPar`
`616`	`616`	`{`
`617`	`617`	`std::promise<response::Value> promise;`
`618`	`618`
`619`		`- promise.set_value(response::Value("Appointment"));`
	`619`	`+ promise.set_value(response::Value(std::string("Appointment")));`
`620`	`620`
`621`	`621`	`return promise.get_future();`
`622`	`622`	`}`
`@@ -659,7 +659,7 @@ std::future<response::Value> Task::resolve__typename(service::ResolverParams&&)`
`659`	`659`	`{`
`660`	`660`	`std::promise<response::Value> promise;`
`661`	`661`
`662`		`- promise.set_value(response::Value("Task"));`
	`662`	`+ promise.set_value(response::Value(std::string("Task")));`
`663`	`663`
`664`	`664`	`return promise.get_future();`
`665`	`665`	`}`
`@@ -702,7 +702,7 @@ std::future<response::Value> Folder::resolve__typename(service::ResolverParams&&`
`702`	`702`	`{`
`703`	`703`	`std::promise<response::Value> promise;`
`704`	`704`
`705`		`- promise.set_value(response::Value("Folder"));`
	`705`	`+ promise.set_value(response::Value(std::string("Folder")));`
`706`	`706`
`707`	`707`	`return promise.get_future();`
`708`	`708`	`}`
`@@ -736,7 +736,7 @@ std::future<response::Value> NestedType::resolve__typename(service::ResolverPara`
`736`	`736`	`{`
`737`	`737`	`std::promise<response::Value> promise;`
`738`	`738`
`739`		`- promise.set_value(response::Value("NestedType"));`
	`739`	`+ promise.set_value(response::Value(std::string("NestedType")));`
`740`	`740`
`741`	`741`	`return promise.get_future();`
`742`	`742`	`}`