Remove fragment overloads in websocket APIs

Author: zhelu2

Binaries/Debug64/run_tests.sh

@@ -70,9 +70,7 @@ namespace details
 /// </summary>
 enum class websocket_message_type
 {
-    text_fragment,
     text_message,
-    binary_fragment,
     binary_message,
     close,
     ping,
@@ -137,15 +135,6 @@ class websocket_outgoing_message
     websocket_outgoing_message()
         : _m_impl(std::make_shared<details::_websocket_message>()) {}
 
-    /// <summary>
-    /// Sets a UTF-8 fragment as the message body.
-    /// </summary>
-    /// <params>UTF-8 String containing body of the fragment.</returns>
-    void set_utf8_fragment(std::string data)
-    {
-        this->_set_message(std::move(data), websocket_message_type::text_fragment);
-    }
-
     /// <summary>
     /// Sets a UTF-8 message as the message body.
     /// </summary>
@@ -155,31 +144,14 @@ class websocket_outgoing_message
         this->_set_message(std::move(data), websocket_message_type::text_message);
     }
 
-    /// <summary>
-    /// Sets a UTF-8 fragment as the message body.
-    /// </summary>
-    /// <params>casablanca input stream representing the body of the fragment.</returns>
-    void set_utf8_fragment(concurrency::streams::istream istream, size_t len)
-    {
-        this->_set_message(istream, len, websocket_message_type::text_fragment);
-    }
-
     /// <summary>
     /// Sets a UTF-8 message as the message body.
     /// </summary>
-    /// <params>casablanca input stream representing the body of the fragment.</returns>
+    /// <params>casablanca input stream representing the body of the message.</returns>
     void set_utf8_message(concurrency::streams::istream istream, size_t len)
     {
         this->_set_message(istream, len, websocket_message_type::text_message);
     }
-    /// <summary>
-    /// Sets a binary fragment as the message body.
-    /// </summary>
-    /// <params>casablanca input stream representing the body of the fragment.</returns>
-    void set_binary_fragment(concurrency::streams::istream istream, size_t len)
-    {
-        this->_set_message(istream, len, websocket_message_type::binary_fragment);
-    }
 
     /// <summary>
     /// Sets binary data as the message body.

Binaries/Release64/run_tests.sh

@@ -83,8 +83,7 @@ std::string details::_websocket_message::_extract_string()
 
 pplx::task<std::string> websocket_incoming_message::extract_string() const
 {
-    if (_m_impl->message_type() == websocket_message_type::binary_fragment ||
-        _m_impl->message_type() == websocket_message_type::binary_message)
+    if (_m_impl->message_type() == websocket_message_type::binary_message)
     {
         return pplx::task_from_exception<std::string>(websocket_exception(_XPLATSTR("Invalid message type")));
     }

Release/include/cpprest/ws_msg.h

@@ -148,25 +148,6 @@ TEST_FIXTURE(uri_address, connect_fail_with_receive)
     VERIFY_THROWS(t.get(), websocket_exception);
 }
 
-#ifdef __cplusplus_winrt
-TEST_FIXTURE(uri_address, send_fragment)
-{
-    std::string body("hello");
-    test_websocket_server server;
-
-    server.next_message([&](test_websocket_msg msg)
-    {
-        websocket_asserts::assert_message_equals(msg, body, test_websocket_message_type::WEB_SOCKET_UTF8_FRAGMENT_TYPE);
-    });
-    websocket_client client(m_uri);
-    client.connect().wait();
-    
-    websocket_outgoing_message msg;
-    msg.set_utf8_fragment(body);
-    VERIFY_THROWS(client.send(msg).wait(), websocket_exception);
-}
-#endif
-
 } // SUITE(error_tests)
 
 }}}}