Fixed Linux server bug where connection::do_response() was called incorrectly without bad_request=true. Removed do_response() default parameter to avoid this issue in the future.

Author: Valtteri Heikkila

Release/include/cpprest/http_linux_server.h

@@ -87,7 +87,7 @@ class connection
     void handle_chunked_body(const boost::system::error_code& ec, int toWrite);
     void dispatch_request_to_listener();
     void request_data_avail(size_t size);
-    void do_response(bool bad_request=false);
+    void do_response(bool bad_request);
     template <typename ReadHandler>
     void async_read_until_buffersize(size_t size, ReadHandler handler);
     void async_process_response(http_response response);

Release/src/http/listener/http_linux_server.cpp

@@ -123,7 +123,7 @@ void connection::handle_http_line(const boost::system::error_code& ec)
         else
         {
             m_request.reply(status_codes::BadRequest);
-            do_response();
+            do_response(true);
         }
     }
     else
@@ -389,12 +389,12 @@ void connection::dispatch_request_to_listener()
     if (pListener == nullptr)
     {
         m_request.reply(status_codes::NotFound);
-        do_response();
+        do_response(false);
     }
     else
     {
         m_request._set_listener_path(pListener->uri().path());
-        do_response();
+        do_response(false);
 
         // Look up the lock for the http_listener.
         pplx::extensibility::reader_writer_lock_t *pListenerLock;