Skip to content

Commit 6c8f948

Browse files
committed
Fix outside tests to use the more stable badssl.com
1 parent 71f0518 commit 6c8f948

File tree

2 files changed

+8
-7
lines changed

2 files changed

+8
-7
lines changed

Release/tests/functional/http/client/outside_tests.cpp

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -151,24 +151,25 @@ TEST_FIXTURE(uri_address, no_transfer_encoding_content_length)
151151
}
152152

153153
// Note additional sites for testing can be found at:
154+
// https://badssl.com/
154155
// https://www.ssllabs.com/ssltest/
155156
// http://www.internetsociety.org/deploy360/resources/dane-test-sites/
156157
// https://onlinessl.netlock.hu/#
157158
TEST(server_selfsigned_cert)
158159
{
159160
handle_timeout([]
160161
{
161-
http_client client(U("https://www.pcwebshop.co.uk/"));
162+
http_client client(U("https://self-signed.badssl.com/"));
162163
auto requestTask = client.request(methods::GET);
163164
VERIFY_THROWS(requestTask.get(), http_exception);
164165
});
165166
}
166167

167-
TEST(server_hostname_mismatch, "Ignore", "Site fixed certificate. Improve test (new site or alternate method).")
168+
TEST(server_hostname_mismatch)
168169
{
169170
handle_timeout([]
170171
{
171-
http_client client(U("https://swordsoftruth.com/"));
172+
http_client client(U("https://wrong.host.badssl.com/"));
172173
auto requestTask = client.request(methods::GET);
173174
VERIFY_THROWS(requestTask.get(), http_exception);
174175
});
@@ -180,7 +181,7 @@ TEST(server_cert_expired)
180181
{
181182
http_client_config config;
182183
config.set_timeout(std::chrono::seconds(1));
183-
http_client client(U("https://tv.eurosport.com/"), config);
184+
http_client client(U("https://expired.badssl.com/"), config);
184185
auto requestTask = client.request(methods::GET);
185186
VERIFY_THROWS(requestTask.get(), http_exception);
186187
});

Release/tests/functional/websockets/client/authentication_tests.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -219,17 +219,17 @@ void handshake_error_test_impl(const ::utility::string_t &host)
219219

220220
TEST(self_signed_cert)
221221
{
222-
handshake_error_test_impl(U("wss://www.pcwebshop.co.uk/"));
222+
handshake_error_test_impl(U("wss://self-signed.badssl.com/"));
223223
}
224224

225225
TEST(hostname_mismatch)
226226
{
227-
handshake_error_test_impl(U("wss://jabbr.net"));
227+
handshake_error_test_impl(U("wss://wrong.host.badssl.com/"));
228228
}
229229

230230
TEST(cert_expired)
231231
{
232-
handshake_error_test_impl(U("wss://tv.eurosport.com/"));
232+
handshake_error_test_impl(U("wss://expired.badssl.com/"));
233233
}
234234

235235
#endif

0 commit comments

Comments
 (0)