Fixed virtual override bug in fileio_linux (and added override keywords)

ras0219-msft · ras0219-msft · commit 77682ebb7a50 · 2014-11-10T13:01:44.000-08:00
diff --git a/Release/src/streams/linux/fileio_linux.cpp b/Release/src/streams/linux/fileio_linux.cpp
@@ -445,12 +445,12 @@ class _filestream_callback_fill_buffer : public _filestream_callback
 public:
     _filestream_callback_fill_buffer(_file_info *info, _filestream_callback *callback, Func func) : m_info(info), m_func(func), m_callback(callback) { }
 
-    virtual void on_completed(size_t result)
+    virtual void on_completed(size_t result) override
     {
         m_func(result);
         delete this;
     }
-    virtual void on_error(const std::exception &e)
+    virtual void on_error(const std::exception_ptr &e) override
     {
         auto exptr = std::make_exception_ptr(e);
         m_callback->on_error(exptr);

Original file line number	Diff line number	Diff line change
`@@ -445,12 +445,12 @@ class _filestream_callback_fill_buffer : public _filestream_callback`
`445`	`445`	`public:`
`446`	`446`	`_filestream_callback_fill_buffer(_file_info info, _filestream_callback callback, Func func) : m_info(info), m_func(func), m_callback(callback) { }`
`447`	`447`
`448`		`- virtual void on_completed(size_t result)`
	`448`	`+ virtual void on_completed(size_t result) override`
`449`	`449`	`{`
`450`	`450`	`m_func(result);`
`451`	`451`	`delete this;`
`452`	`452`	`}`
`453`		`- virtual void on_error(const std::exception &e)`
	`453`	`+ virtual void on_error(const std::exception_ptr &e) override`
`454`	`454`	`{`
`455`	`455`	`auto exptr = std::make_exception_ptr(e);`
`456`	`456`	`m_callback->on_error(exptr);`