Add exception handling for the ssl_context_callback so it has a means to report errors

Author: garethsb

Release/src/http/client/http_client_asio.cpp

@@ -631,7 +631,15 @@ class asio_context final : public request_context, public std::enable_shared_fro
                 m_context->m_timer.reset();
                 //// Replace the connection. This causes old connection object to go out of scope.
                 auto client = std::static_pointer_cast<asio_client>(m_context->m_http_client);
-                m_context->m_connection = client->obtain_connection(m_context->m_request);
+                try
+                {
+                    m_context->m_connection = client->obtain_connection(m_context->m_request);
+                }
+                catch (...)
+                {
+                    m_context->report_exception(std::current_exception());
+                    return;
+                }
 
                 auto endpoint = *endpoints;
                 m_context->m_connection->async_connect(endpoint,
@@ -688,7 +696,15 @@ class asio_context final : public request_context, public std::enable_shared_fro
                     return;
                 }
 
-                m_context->upgrade_to_ssl();
+                try
+                {
+                    m_context->upgrade_to_ssl();
+                }
+                catch (...)
+                {
+                    m_context->report_exception(std::current_exception());
+                    return;
+                }
 
                 m_ssl_tunnel_established(m_context);
             }
@@ -1009,7 +1025,15 @@ class asio_context final : public request_context, public std::enable_shared_fro
         {
             // Replace the connection. This causes old connection object to go out of scope.
             auto client = std::static_pointer_cast<asio_client>(m_http_client);
-            m_connection = client->obtain_connection(m_request);
+            try
+            {
+                m_connection = client->obtain_connection(m_request);
+            }
+            catch (...)
+            {
+                request_context::report_exception(std::current_exception());
+                return;
+            }
 
             auto endpoint = *endpoints;
             m_connection->async_connect(
@@ -1330,7 +1354,16 @@ class asio_context final : public request_context, public std::enable_shared_fro
             // Create a new context and copy the request object, completion event and
             // cancellation registration to maintain the old state.
             // This also obtains a new connection from pool.
-            auto new_ctx = create_request_context(m_http_client, m_request);
+            std::shared_ptr<request_context> new_ctx;
+            try
+            {
+                new_ctx = create_request_context(m_http_client, m_request);
+            }
+            catch (...)
+            {
+                report_exception(std::current_exception());
+                return;
+            }
 
             // If the request contains a valid instream, we try to rewind it to
             // replay the just-failed request. Otherwise we assume that no data
@@ -1940,7 +1973,15 @@ void asio_client::send_request(const std::shared_ptr<request_context>& request_c
 pplx::task<http_response> asio_client::propagate(http_request request)
 {
     auto self = std::static_pointer_cast<_http_client_communicator>(shared_from_this());
-    auto context = details::asio_context::create_request_context(self, request);
+    std::shared_ptr<request_context> context;
+    try
+    {
+        context = details::asio_context::create_request_context(self, request);
+    }
+    catch (...)
+    {
+        return pplx::task_from_exception<http_response>(std::current_exception());
+    }
 
     // Use a task to externally signal the final result and completion of the task.
     auto result_task = pplx::create_task(context->m_request_completion);