Removing unnecessary sync() call from winrt http_client and exception check from desktop client.

Author: stgates

Release/src/http/client/http_win7.cpp

@@ -835,20 +835,16 @@ class winhttp_client : public _http_client_communicator
                 }
                 _ASSERTE(read != static_cast<size_t>(-1));
 
-                if ( read == 0 )
+                if (read == 0)
                 {
-                    // Unexpected end-of-stream.
-                    if (!(rbuf.exception() == nullptr))
-                        p_request_context->report_exception(rbuf.exception());
-                    else
-                        p_request_context->report_error(GetLastError(), _XPLATSTR("Error reading outgoing HTTP body from its stream."));
+                    p_request_context->report_exception(http_exception(U("Unexpected end of request body stream encountered before Content-Length met.")));
                     return;
                 }
 
                 p_request_context->m_remaining_to_write -= read;
 
                 // Stop writing chunks after this one if no more data.
-                if ( p_request_context->m_remaining_to_write == 0 )
+                if (p_request_context->m_remaining_to_write == 0)
                 {
                     p_request_context->m_bodyType = no_body;
                 }

Release/src/http/client/http_win8.cpp

@@ -279,16 +279,15 @@ class IResponseStream
             *pcbWritten = 0;
         }
 
+        if (cb == 0)
+        {
+            return S_OK;
+        }
+
         try
         {
             auto buffer = context->_get_writebuffer();
-            if ( cb == 0 )
-            {
-                buffer.sync().wait();
-                return S_OK;
-            }
-
-            const size_t count = buffer.putn((const uint8_t *)pv, (size_t)cb).get();
+            const size_t count = buffer.putn(reinterpret_cast<uint8_t *>(pv), static_cast<size_t>(cb)).get();
 
             _ASSERTE(count != static_cast<size_t>(-1));
             _ASSERTE(count <= static_cast<size_t>(ULONG_MAX));
@@ -299,7 +298,7 @@ class IResponseStream
             context->m_downloaded += count;
 
             auto progress = context->m_request._get_impl()->_progress_handler();
-            if ( progress && count > 0 )
+            if (progress && count > 0)
             {
                 try { (*progress)(message_direction::download, context->m_downloaded); } catch(...)
                 {