Fixing bug in Asio http_client where if TLS is used and a connection is reused the handshake is performed twice.

Author: stgates

Release/src/http/client/http_client_asio.cpp

@@ -542,7 +542,8 @@ class asio_context : public request_context, public std::enable_shared_from_this
 
     void write_request()
     {
-        if (m_connection->is_ssl())
+        // Only perform handshake if a TLS connection and not being reused.
+        if (m_connection->is_ssl() && !m_connection->is_reused())
         {
             const auto weakCtx = std::weak_ptr<asio_context>(shared_from_this());
             m_connection->async_handshake(boost::asio::ssl::stream_base::client,

Release/tests/functional/http/client/outside_tests.cpp

@@ -115,6 +115,22 @@ TEST_FIXTURE(uri_address, outside_google_dot_com)
 #endif
     });
 }
+    
+TEST_FIXTURE(uri_address, multiple_https_requests)
+{
+    handle_timeout([&]
+    {
+        http_client client(U("https://www.google.com"));
+    
+        http_response response;
+        for(int i = 0; i < 5; ++i)
+        {
+            response = client.request(methods::GET).get();
+            VERIFY_ARE_EQUAL(status_codes::OK, response.status_code());
+            response.content_ready().wait();
+        }
+    });
+}
 
 TEST_FIXTURE(uri_address, reading_google_stream)
 {