Resolved warning in BlackJackClient, switched to using std::mutex, and now using ENOINT on linux for file-not-found

Author: ras0219-msft

Release/collateral/Samples/BlackJack/BlackJack_Client/BlackJackClient.cpp

@@ -35,7 +35,7 @@
 #endif
 
 using namespace std;
-using namespace web; 
+using namespace web;
 using namespace utility;
 using namespace http;
 using namespace http::client;
@@ -62,6 +62,7 @@ void PrintResult(BJHandResult result)
     case HR_PlayerWin: ucout << "Player wins"; break;
     case HR_ComputerWin: ucout << "Computer Wins"; break;
     case HR_Push:ucout << "Push"; break;
+    default: std::abort();
     }
 }
 
@@ -141,6 +142,8 @@ void PrintTable(const http_response &response, bool &refresh)
             case ST_YourTurn:
                 ucout << "Your turn!\n";
                 break;
+            default:
+                std::abort();
             }
         }
     }

Release/include/pplx/pplxlinux.h

@@ -46,11 +46,6 @@
 #include "compat/linux_compat.h"
 #endif
 
-#include "boost/thread/mutex.hpp"
-#include "boost/thread/condition_variable.hpp"
-#include "boost/date_time/posix_time/posix_time_types.hpp"
-#include "boost/bind/bind.hpp"
-
 #include "pplx/pplxinterface.h"
 
 
@@ -240,11 +235,7 @@ namespace platform
         }
 
     private:
-#if defined(__APPLE__)
-        std::mutex _M_cs;
-#else
-        ::boost::mutex _M_cs;
-#endif
+        ::std::mutex _M_cs;
         long _M_recursionCount;
         volatile long _M_owner;
     };
@@ -326,7 +317,7 @@ namespace extensibility
 {
     typedef ::pplx::details::event_impl event_t;
 
-    typedef ::boost::mutex critical_section_t;
+    typedef ::std::mutex critical_section_t;
     typedef scoped_lock<critical_section_t> scoped_critical_section_t;
 
     typedef ::pplx::details::reader_writer_lock_impl reader_writer_lock_t;

Release/src/streams/linux/fileio_linux.cpp

@@ -73,7 +73,7 @@ class io_scheduler
     void submit_io()
     {
         m_no_outstanding_work.reset();
-        ++m_outstanding_work; 
+        ++m_outstanding_work;
     }
 
     void complete_io()
@@ -176,7 +176,7 @@ using namespace Concurrency::streams::details;
 /// <returns>The error code if there was an error in file creation.</returns>
 bool _finish_create(int fh, _filestream_callback *callback, std::ios_base::openmode mode, int /* prot */)
 {
-    if ( fh != -1 ) 
+    if ( fh != -1 )
     {
         std::shared_ptr<io_scheduler> sched = get_scheduler();
 
@@ -185,7 +185,7 @@ bool _finish_create(int fh, _filestream_callback *callback, std::ios_base::openm
         // letting the OS do its buffering, even if it means that prompt reads won't
         // happen.
         bool buffer = (mode == std::ios_base::in);
-        
+
         // seek to end if requested
         if (mode & std::ios_base::ate)
         {
@@ -204,11 +204,8 @@ bool _finish_create(int fh, _filestream_callback *callback, std::ios_base::openm
     }
     else
     {
-#ifdef __APPLE__
-        auto exptr = std::make_exception_ptr(std::ios_base::failure("failed to create file", std::make_error_code(std::errc::no_such_file_or_directory)));
-#else
-        auto exptr = std::make_exception_ptr(std::ios_base::failure("failed to create file"));
-#endif
+        auto enoint = std::make_error_code(std::errc::no_such_file_or_directory);
+        auto exptr = std::make_exception_ptr(std::ios_base::failure("failed to create file", enoint));
         callback->on_error(exptr);
         return false;
     }