Fixing incorrect assumption in code about thread safetly of initialization of function local static variables. VS 2013 didn't implement magic statics.

Author: stgates

Release/include/cpprest/details/http_helpers.h

@@ -81,6 +81,11 @@ namespace details
     /// </summary>
     utility::string_t get_default_charset(const utility::string_t &content_type);
 
+    /// <summary>
+    /// Helper function to get the default HTTP reason phrase for a status code.
+    /// </summary>
+    utility::string_t get_default_reason_phrase(status_code code);
+
     /// <summary>
     /// Helper functions to convert a series of bytes from a charset to utf-8 or utf-16.
     /// These APIs deal with checking for and handling byte order marker (BOM).

Release/include/cpprest/oauth1.h

@@ -135,6 +135,11 @@ class oauth1_token
 {
 public:
 
+    /// <summary>
+    /// Constructs an initially empty invalid access token.
+    /// </summary>
+    oauth1_token() {}
+
     /// <summary>
     /// Constructs a OAuth1 token from a given access token and secret.
     /// </summary>
@@ -222,8 +227,6 @@ class oauth1_token
 private:
     friend class oauth1_config;
 
-    oauth1_token() {}
-
     utility::string_t m_token;
     utility::string_t m_secret;
     std::map<utility::string_t, utility::string_t> m_additional_parameters;
@@ -366,21 +369,7 @@ class oauth1_config
     /// Get token.
     /// </summary>
     /// <returns>Token.</returns>
-    const oauth1_token& token() const
-    {
-        if (m_is_authorization_completed)
-        {
-            // Return the token object only if authorization has been completed.
-            // Otherwise the token object holds a temporary token which should not be
-            // returned to the user.
-            return m_token;
-        }
-        else
-        {
-            static const oauth1_token empty_token;
-            return empty_token;
-        }
-    }
+    _ASYNCRTIMP const oauth1_token& token() const;
 
     /// <summary>
     /// Set token.

Release/src/http/client/http_client_msg.cpp

@@ -86,22 +86,7 @@ utility::string_t details::_http_response::to_string() const
     auto reason_phrase = m_reason_phrase;
     if(reason_phrase.empty())
     {
-        static http_status_to_phrase idToPhraseMap[] = {
-#define _PHRASES
-#define DAT(a,b,c) {status_codes::a, c},
-#include "cpprest/details/http_constants.dat"
-#undef _PHRASES
-#undef DAT
-        };
-
-        for( auto iter = std::begin(idToPhraseMap); iter != std::end(idToPhraseMap); ++iter)
-        {
-            if( iter->id == status_code() )
-            {
-                reason_phrase = iter->phrase;
-                break;
-            }
-        }
+        reason_phrase = get_default_reason_phrase(status_code());
     }
 
     utility::ostringstream_t buffer;