Skip to content

Commit dadb447

Browse files
committed
Fixing conflicting name missed by msvc and an early move in http_client_impl.h
1 parent 63848d9 commit dadb447

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

Release/include/cpprest/base_uri.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -277,7 +277,7 @@ namespace web {
277277
if (this != &other)
278278
{
279279
m_uri = std::move(other.m_uri);
280-
m_components = std::move(m_components);
280+
m_components = std::move(other.m_components);
281281
}
282282
return *this;
283283
}

Release/include/cpprest/http_client_impl.h

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -299,7 +299,7 @@ class _http_client_communicator
299299
return m_client_config;
300300
}
301301

302-
const uri & uri() const
302+
const uri & base_uri() const
303303
{
304304
return m_uri;
305305
}
@@ -461,15 +461,15 @@ void http_client::build_pipeline(uri base_uri, http_client_config client_config)
461461
}
462462
details::verify_uri(base_uri);
463463

464+
m_pipeline = ::web::http::http_pipeline::create_pipeline(std::make_shared<details::http_network_handler>(std::move(base_uri), std::move(client_config)));
465+
464466
#if !defined(CPPREST_TARGET_XP) && !defined(_PHONE8_)
465467
add_handler(std::static_pointer_cast<http::http_pipeline_stage>(
466-
std::make_shared<oauth1::details::oauth1_handler>(client_config.oauth1())));
468+
std::make_shared<oauth1::details::oauth1_handler>(this->client_config().oauth1())));
467469
#endif // !defined(CPPREST_TARGET_XP) && !defined(_PHONE8_)
468470

469471
add_handler(std::static_pointer_cast<http::http_pipeline_stage>(
470-
std::make_shared<oauth2::details::oauth2_handler>(client_config.oauth2())));
471-
472-
m_pipeline = ::web::http::http_pipeline::create_pipeline(std::make_shared<details::http_network_handler>(std::move(base_uri), std::move(client_config)));
472+
std::make_shared<oauth2::details::oauth2_handler>(this->client_config().oauth2())));
473473
}
474474

475475
const http_client_config & http_client::client_config() const
@@ -481,7 +481,7 @@ const http_client_config & http_client::client_config() const
481481
const uri & http_client::base_uri() const
482482
{
483483
auto ph = std::static_pointer_cast<details::http_network_handler>(m_pipeline->last_stage());
484-
return ph->http_client_impl()->uri();
484+
return ph->http_client_impl()->base_uri();
485485
}
486486

487487
}}} // namespaces

0 commit comments

Comments
 (0)