Fix more warnings caught by CI build

Author: dmachaj

test/test/disconnected.cpp

@@ -148,7 +148,7 @@ struct non_agile_abandoned_action : implements<non_agile_abandoned_action, IAsyn
 {
     non_agile_abandoned_action(delegate<> disconnect) : m_disconnect(disconnect) {}
 
-    static fire_and_forget final_release(std::unique_ptr<non_agile_abandoned_action> self)
+    static fire_and_forget final_release(std::unique_ptr<non_agile_abandoned_action> /*self*/)
     {
         // The C++/WinRT m_handler is agile but not context-aware,
         // so we need to make sure to release it from the context it

test/test/event_deferral.cpp

@@ -38,7 +38,7 @@ namespace
         // This exercises the short-circuit logic in deferrable_event_args.
         auto NoDeferralHandler()
         {
-            return [=](Class const& sender, DeferrableEventArgs const& args)
+            return [=, this](Class const& sender, DeferrableEventArgs const& args)
             {
                 REQUIRE(sender == c);
                 args.IncrementCounter();
@@ -50,7 +50,7 @@ namespace
         // deferrable_event_args.
         auto PointlessDeferralHandler()
         {
-            return [=](Class const& sender, DeferrableEventArgs const& args)
+            return [=, this](Class const& sender, DeferrableEventArgs const& args)
             {
                 REQUIRE(sender == c);
                 auto deferral = args.GetDeferral();
@@ -61,7 +61,7 @@ namespace
 
         auto TakeDeferralHandler(int startState, int finishState)
         {
-            return [=](Class sender, DeferrableEventArgs args) -> fire_and_forget
+            return [=, this](Class sender, DeferrableEventArgs args) -> fire_and_forget
             {
                 REQUIRE(sender == c);
                 auto deferral = args.GetDeferral();

test/test/inspectable_interop.cpp

@@ -41,11 +41,18 @@ namespace
 #ifdef __GNUC__
 #pragma GCC diagnostic push
 #pragma GCC diagnostic ignored "-Woverloaded-virtual"
+#endif
+#ifdef __clang__
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Woverloaded-virtual"
 #endif
         Windows::Foundation::TrustLevel GetTrustLevel() const noexcept
         {
             return Windows::Foundation::TrustLevel::PartialTrust;
         }
+#ifdef __clang__
+#pragma clang diagnostic pop
+#endif
 #ifdef __GNUC__
 #pragma GCC diagnostic pop
 #endif

test/test/multi_threaded_map.cpp

@@ -90,7 +90,7 @@ namespace
         using const_reverse_iterator = std::reverse_iterator<const_iterator>;
         using node_type = typename inner::node_type;
 
-        mapped_type& operator[](const key_type& key)
+        mapped_type& operator[](const key_type& /*key*/)
         {
             auto guard = concurrency_guard::lock_nonconst();
             concurrency_guard::call_hook(collection_action::at);

test/test/out_params.cpp

@@ -134,7 +134,7 @@ TEST_CASE("out_params")
         REQUIRE(value[3] == nullptr);
     }
     {
-        std::array<Struct, 3> value{ {L"First", L"Second"} };
+        std::array<Struct, 3> value{ { { L"First" }, { L"Second"} } };
         object.RefStructArray(value);
         REQUIRE(value[0].First == L"1");
         REQUIRE(value[0].Second == L"2");
@@ -260,7 +260,7 @@ TEST_CASE("out_params")
         REQUIRE(value[3] == nullptr);
     }
     {
-        std::array<Struct, 3> value{ {L"First", L"Second"} };
+        std::array<Struct, 3> value{ { { L"First" }, { L"Second"} } };
         REQUIRE_THROWS_AS(object.RefStructArray(value), hresult_invalid_argument);
         REQUIRE(value[0].First == L"");
         REQUIRE(value[0].Second == L"");

test/test/return_params_abi.cpp

@@ -10,16 +10,6 @@ namespace winrt
 
 using namespace winrt;
 
-namespace
-{
-    hstring to_hstring(::IInspectable* raw)
-    {
-        winrt::IInspectable object;
-        copy_from_abi(object, raw);
-        return object.as<IStringable>().ToString();
-    }
-}
-
 TEST_CASE("return_params_abi")
 {
     Class object;

test/test/struct_delegate.cpp

@@ -1,5 +1,5 @@
 #include "pch.h"
-#include "winrt/test_component.delegates.h"
+#include "winrt/test_component.Delegates.h"
 
 using namespace winrt;
 using namespace test_component;

test/test_component/Class.cpp

@@ -519,7 +519,14 @@ namespace winrt::test_component::implementation
 
 namespace
 {
+#ifdef __clang__
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wunused-function"
+#endif
     void ValidateStaticEventAutoRevoke() {
         auto x = winrt::test_component::Simple::StaticEvent(winrt::auto_revoke, [](auto&&, auto&&) {});
     }
+#ifdef __clang__
+#pragma clang diagnostic pop
+#endif
 }