Convert checker from pwsh back to batch file so it can access VS environment variables

Author: dmachaj

.github/workflows/ci.yml

@@ -13,38 +13,40 @@ jobs:
     steps:
       - uses: actions/checkout@v4
 
-      - name: Check Formatting
+      - name: Find vcvars64.bat
         run: |
           $vcvars64 = & "${env:ProgramFiles(x86)}\Microsoft Visual Studio\Installer\vswhere" -latest -find VC\Auxiliary\Build\vcvars64.bat
           if (!$vcvars64) { exit 1 }
           Write-Host "Using vcvars64: ${vcvars64}"
+          Add-Content $env:GITHUB_ENV "vcvars64=$vcvars64"
 
-          # We need environment variables from running a batch file, but are running pwsh, so they would all be lost when cmd exits.  We
-          # circumvent this problem by launching a fresh pwsh process after the batch file runs so execution continues with them set.
-          cmd "/k" '"C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Auxiliary\Build\vcvars64.bat" & pwsh'
-
-          & .\find_clang_format.cmd
-          if ($LASTEXITCODE -ne 0) {
-            exit $LASTEXITCODE
-          }
-
-          & git clang-format origin/master --binary "$env:CLANG_FORMAT" --style file -- cppwinrt/*.h cppwinrt/*.cpp fast_fwd/*.h fast_fwd/*.cpp prebuild/*.h prebuild/*.cpp scratch/*.h scratch/*.cpp strings/*.h strings/*.cpp test/*.h test/*.cpp vsix/*.h vsix/*.cpp
-
-          if ($LASTEXITCODE -ne 0) {
-            Write-Host ::error ERROR: This branch contains changes that have not been formatted with `'clang-format`'
-            Write-Host NOTE:  To resolve this issue, you can run `'clang-format`' in the following ways:
-            Write-Host        * Run ``build_test_all.cmd`` which will run `'clang-format`' on _all_ source files. This script is
-            Write-Host          simpler to run, however there`'s a chance it may touch additional files you never changed due to you having
-            Write-Host          a mis-matched version of `'clang-format`'. This may require you to manually revert changes made by
-            Write-Host          `'clang-format`' to the locations where you made no code changes.
-            Write-Host
-            Write-Host        For more information, please see https://github.com/microsoft/cppwinrt?tab=readme-ov-file#formatting
-            Write-Host
-            Write-Host NOTE:  As an additional note, given that different versions of `'clang-format`' may have different behaviors, this
-            Write-Host        may be a false positive. If you believe that to be the case ^`(e.g. none of the above resulted in modifications
-            Write-Host        to the code you have changed^`), please note this in your PR.
-            exit 1
-          }
+      - name: Check Formatting
+        shell: cmd
+        run: |
+          call "%vcvars64%"
+
+          call .\find_clang_format.cmd
+          if %ERRORLEVEL% neq 0 (
+            exit /b %ERRORLEVEL%
+          )
+
+          git clang-format origin/master --binary "%CLANG_FORMAT%" --style file -- cppwinrt/*.h cppwinrt/*.cpp fast_fwd/*.h fast_fwd/*.cpp prebuild/*.h prebuild/*.cpp scratch/*.h scratch/*.cpp strings/*.h strings/*.cpp test/*.h test/*.cpp vsix/*.h vsix/*.cpp
+
+          if %ERRORLEVEL% neq 0 (
+            echo ::error ERROR: This branch contains changes that have not been formatted with 'clang-format'
+            echo NOTE:  To resolve this issue, you can run 'clang-format' in the following ways:
+            echo        * Run build_test_all.cmd which will run 'clang-format' on _all_ source files. This script is
+            echo          simpler to run, however there's a chance it may touch additional files you never changed due to you having
+            echo          a mis-matched version of 'clang-format'. This may require you to manually revert changes made by
+            echo          'clang-format' to the locations where you made no code changes.
+            echo.
+            echo        For more information, please see https://github.com/microsoft/cppwinrt?tab=readme-ov-file#formatting
+            echo.
+            echo NOTE:  As an additional note, given that different versions of 'clang-format' may have different behaviors, this
+            echo        may be a false positive. If you believe that to be the case ^(e.g. none of the above resulted in modifications
+            echo        to the code you have changed^), please note this in your PR.
+            exit /b 1
+          )
 
   test-msvc-cppwinrt-build:
     name: '${{ matrix.compiler }}: Build (${{ matrix.arch }}, ${{ matrix.config }})'