Try to clean some analysis warnings.

DefaultRyan · DefaultRyan · commit 3f0895e50391 · 2025-01-30T12:33:52.000-08:00
diff --git a/natvis/cppwinrt_visualizer.cpp b/natvis/cppwinrt_visualizer.cpp
@@ -273,7 +273,7 @@ cppwinrt_visualizer::~cppwinrt_visualizer()
 
 HRESULT cppwinrt_visualizer::EvaluateVisualizedExpression(
     _In_ DkmVisualizedExpression* pVisualizedExpression,
-    _Deref_out_ DkmEvaluationResult** ppResultObject
+    _COM_Outptr_result_maybenull_ DkmEvaluationResult** ppResultObject
 )
 {
     try
@@ -313,6 +313,7 @@ HRESULT cppwinrt_visualizer::EvaluateVisualizedExpression(
             // unrecognized type
             NatvisDiagnostic(pVisualizedExpression, 
                 std::wstring(L"Unrecognized type: ") + (LPWSTR)bstrTypeName,  NatvisDiagnosticLevel::Error);
+            *ppResultObject = nullptr;
             return S_OK;
         }
 
diff --git a/natvis/cppwinrt_visualizer.h b/natvis/cppwinrt_visualizer.h
@@ -8,7 +8,7 @@ struct cppwinrt_visualizer : winrt::implements<cppwinrt_visualizer,
 
     STDMETHOD(EvaluateVisualizedExpression)(
         _In_ Microsoft::VisualStudio::Debugger::Evaluation::DkmVisualizedExpression* pVisualizedExpression,
-        _Deref_out_ Microsoft::VisualStudio::Debugger::Evaluation::DkmEvaluationResult** ppResultObject
+        _COM_Outptr_result_maybenull_ Microsoft::VisualStudio::Debugger::Evaluation::DkmEvaluationResult** ppResultObject
         );
     STDMETHOD(UseDefaultEvaluationBehavior)(
         _In_ Microsoft::VisualStudio::Debugger::Evaluation::DkmVisualizedExpression* pVisualizedExpression,

Original file line number	Diff line number	Diff line change
`@@ -273,7 +273,7 @@ cppwinrt_visualizer::~cppwinrt_visualizer()`
`273`	`273`
`274`	`274`	`HRESULT cppwinrt_visualizer::EvaluateVisualizedExpression(`
`275`	`275`	`_In_ DkmVisualizedExpression* pVisualizedExpression,`
`276`		`- _Deref_out_ DkmEvaluationResult** ppResultObject`
	`276`	`+ _COM_Outptr_result_maybenull_ DkmEvaluationResult** ppResultObject`
`277`	`277`	`)`
`278`	`278`	`{`
`279`	`279`	`try`
`@@ -313,6 +313,7 @@ HRESULT cppwinrt_visualizer::EvaluateVisualizedExpression(`
`313`	`313`	`// unrecognized type`
`314`	`314`	`NatvisDiagnostic(pVisualizedExpression,`
`315`	`315`	`std::wstring(L"Unrecognized type: ") + (LPWSTR)bstrTypeName, NatvisDiagnosticLevel::Error);`
	`316`	`+ *ppResultObject = nullptr;`
`316`	`317`	`return S_OK;`
`317`	`318`	`}`
`318`	`319`