terminate must be noreturn (#527)

kennykerr · web-flow · commit 61c8fed33962 · 2020-02-13T07:22:24.000-08:00
diff --git a/strings/base_error.h b/strings/base_error.h
@@ -565,10 +565,11 @@ WINRT_EXPORT namespace winrt
         return pointer;
     }
 
-    inline void terminate() noexcept
+    [[noreturn]] inline void terminate() noexcept
     {
         static void(__stdcall * handler)(int32_t) noexcept;
         impl::load_runtime_function("RoFailFastWithErrorContext", handler, impl::fallback_RoFailFastWithErrorContext);
         handler(to_hresult());
+        abort();
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -565,10 +565,11 @@ WINRT_EXPORT namespace winrt`
`565`	`565`	`return pointer;`
`566`	`566`	`}`
`567`	`567`
`568`		`- inline void terminate() noexcept`
	`568`	`+ [[noreturn]] inline void terminate() noexcept`
`569`	`569`	`{`
`570`	`570`	`static void(__stdcall * handler)(int32_t) noexcept;`
`571`	`571`	`impl::load_runtime_function("RoFailFastWithErrorContext", handler, impl::fallback_RoFailFastWithErrorContext);`
`572`	`572`	`handler(to_hresult());`
	`573`	`+ abort();`
`573`	`574`	`}`
`574`	`575`	`}`