Single-parameter constructors should be explicit (#422)

kennykerr · web-flow · commit 6218c03bdf4c · 2019-11-15T10:42:02.000-08:00
diff --git a/cppwinrt/code_writers.h b/cppwinrt/code_writers.h
@@ -2777,7 +2777,8 @@ struct __declspec(empty_bases) produce_dispatch_to_overridable<T, D, %>
                     {
                         method_signature signature{ method };
 
-                        w.write("        %(%);\n",
+                        w.write("        %%(%);\n",
+                            signature.params().size() == 1 ? "explicit " : "",
                             type_name,
                             bind<write_consume_params>(signature));
                     }
@@ -2791,7 +2792,8 @@ struct __declspec(empty_bases) produce_dispatch_to_overridable<T, D, %>
                     auto& params = signature.params();
                     params.resize(params.size() - 2);
 
-                    w.write("        %(%);\n",
+                    w.write("        %%(%);\n",
+                        signature.params().size() == 1 ? "explicit " : "",
                         type_name,
                         bind<write_consume_params>(signature));
                 }

Original file line number	Diff line number	Diff line change
`@@ -2777,7 +2777,8 @@ struct __declspec(empty_bases) produce_dispatch_to_overridable<T, D, %>`
`2777`	`2777`	`{`
`2778`	`2778`	`method_signature signature{ method };`
`2779`	`2779`
`2780`		`- w.write(" %(%);\n",`
	`2780`	`+ w.write(" %%(%);\n",`
	`2781`	`+ signature.params().size() == 1 ? "explicit " : "",`
`2781`	`2782`	`type_name,`
`2782`	`2783`	`bind<write_consume_params>(signature));`
`2783`	`2784`	`}`
`@@ -2791,7 +2792,8 @@ struct __declspec(empty_bases) produce_dispatch_to_overridable<T, D, %>`
`2791`	`2792`	`auto& params = signature.params();`
`2792`	`2793`	`params.resize(params.size() - 2);`
`2793`	`2794`
`2794`		`- w.write(" %(%);\n",`
	`2795`	`+ w.write(" %%(%);\n",`
	`2796`	`+ signature.params().size() == 1 ? "explicit " : "",`
`2795`	`2797`	`type_name,`
`2796`	`2798`	`bind<write_consume_params>(signature));`
`2797`	`2799`	`}`