Replace "custom llvm" msbuild props with PlatformToolset=ClangCl

DefaultRyan · DefaultRyan · commit 8b17c89236ab · 2025-02-28T12:16:45.000-08:00
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -44,7 +44,7 @@ jobs:
           $target_version = "1.2.3.4"
           $props = "Configuration=$target_configuration,Platform=$target_platform,CppWinRTBuildVersion=$target_version"
           if ("${{ matrix.compiler }}" -eq "clang-cl") {
-            $props += ",Clang=1,PlatformToolset=LLVM_v143,LLVMInstallDir=${{ steps.setup-llvm.outputs.llvm-path }}"
+            $props += ",Clang=1,PlatformToolset=ClangCl"
           }
           Add-Content $env:GITHUB_ENV "msbuild_config_props=/p:$props"
 

Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,7 @@ jobs:`
`44`	`44`	`$target_version = "1.2.3.4"`
`45`	`45`	`$props = "Configuration=$target_configuration,Platform=$target_platform,CppWinRTBuildVersion=$target_version"`
`46`	`46`	`if ("${{ matrix.compiler }}" -eq "clang-cl") {`
`47`		`- $props += ",Clang=1,PlatformToolset=LLVM_v143,LLVMInstallDir=${{ steps.setup-llvm.outputs.llvm-path }}"`
	`47`	`+ $props += ",Clang=1,PlatformToolset=ClangCl"`
`48`	`48`	`}`
`49`	`49`	`Add-Content $env:GITHUB_ENV "msbuild_config_props=/p:$props"`
`50`	`50`