Don't free the apartment_context while we are still using it (#691)

oldnewthing · web-flow · commit 9ddc0bb4e767 · 2020-07-14T10:39:23.000-07:00
diff --git a/strings/base_coroutine_threadpool.h b/strings/base_coroutine_threadpool.h
@@ -336,7 +336,8 @@ WINRT_EXPORT namespace winrt
 
         void await_suspend(std::experimental::coroutine_handle<> handle) const
         {
-            impl::resume_apartment(context, handle);
+            auto copy = context; // resuming may destruct *this, so use a copy
+            impl::resume_apartment(copy, handle);
         }
 
         impl::resume_apartment_context context;

Original file line number	Diff line number	Diff line change
`@@ -336,7 +336,8 @@ WINRT_EXPORT namespace winrt`
`336`	`336`
`337`	`337`	`void await_suspend(std::experimental::coroutine_handle<> handle) const`
`338`	`338`	`{`
`339`		`- impl::resume_apartment(context, handle);`
	`339`	`+ auto copy = context; // resuming may destruct *this, so use a copy`
	`340`	`+ impl::resume_apartment(copy, handle);`
`340`	`341`	`}`
`341`	`342`
`342`	`343`	`impl::resume_apartment_context context;`