lint: no-var rule

Author: danmarshall

eslint.config.js

@@ -30,7 +30,6 @@ export default [
       "@typescript-eslint/no-unused-vars": "off",
       "no-empty-pattern": "off",
       "no-empty": "off",
-      "no-var": "off",
       "no-unsafe-optional-chaining": "off",
       "no-useless-escape": "off",
       "prefer-const": "off",

src/app/App.tsx

@@ -124,8 +124,8 @@ export const ExportStateButton: React.FC<{}> = ({}) => {
     return <Tooltip title="save session locally">
         <Button variant="text" onClick={()=>{
             function download(content: string, fileName: string, contentType: string) {
-                    var a = document.createElement("a");
-                    var file = new Blob([content], {type: contentType});
+                    let a = document.createElement("a");
+                    let file = new Blob([content], {type: contentType});
                     a.href = URL.createObjectURL(file);
                     a.download = fileName;
                     a.click();

src/data/utils.ts

@@ -139,7 +139,7 @@ export function tupleEqual(a: any[], b: any[]) {
     if (a === b) return true;
     if (a == null || b == null) return false;
     if (a.length !== b.length) return false;
-    for (var i = 0; i < a.length; ++i) {
+    for (let i = 0; i < a.length; ++i) {
         if (a[i] !== b[i]) return false;
     }
     return true;

src/views/DataThread.tsx

@@ -381,11 +381,11 @@ export const DataThread: FC<{}> = function ({ }) {
             assembledChart = (({ data, ...o }) => o)(assembledChart);
 
             let getRandom = (seed: number) => {
-                var x = Math.sin(seed++) * 10000;
+                let x = Math.sin(seed++) * 10000;
                 return x - Math.floor(x);
             }
             let getRandomSubarray = (arr: any[], size: number) => {
-                var shuffled = arr.slice(0), i = arr.length, temp, index;
+                let shuffled = arr.slice(0), i = arr.length, temp, index;
                 while (i--) {
                     index = Math.floor((i + 1) * getRandom(233 * i + 888));
                     temp = shuffled[index];

src/views/EncodingShelfThread.tsx

@@ -90,11 +90,11 @@ export let ChartElementFC: FC<{chart: Chart, tableRows: any[], boxWidth?: number
         assembledChart = (({ data, ...o }) => o)(assembledChart);
 
         let getRandom = (seed: number) => {
-            var x = Math.sin(seed++) * 10000;
+            let x = Math.sin(seed++) * 10000;
             return x - Math.floor(x);
         }
         let getRandomSubarray = (arr: any[], size: number) => {
-            var shuffled = arr.slice(0), i = arr.length, temp, index;
+            let shuffled = arr.slice(0), i = arr.length, temp, index;
             while (i--) {
                 index = Math.floor((i + 1) * getRandom(233 * i + 888));
                 temp = shuffled[index];