Merge pull request #270 from microsoft/v1.9.3

split part fix for -ve part numbers and removed generate_custom_schema macro in the adapter

Author: prdpsvs

dbt/adapters/fabric/__version__.py

@@ -1 +1 @@
-version = "1.9.2"
+version = "1.9.3"

dbt/include/fabric/macros/materializations/tests/helpers.sql

@@ -52,14 +52,3 @@
   SELECT * FROM dbt_internal_unit_test_expected
 
 {%- endmacro %}
-
-
-{% macro fabric__generate_schema_name(custom_schema_name, node) -%}
-
-    {%- set default_schema = target.schema -%}
-    {%- if custom_schema_name is none -%}
-        {{ default_schema }}
-    {%- else -%}
-        {{ custom_schema_name | trim }}
-    {%- endif -%}
-{%- endmacro %}

dbt/include/fabric/macros/utils/split_part.sql

@@ -1,8 +1,19 @@
 {% macro fabric__split_part(string_text, delimiter_text, part_number) %}
-    {% if part_number >= 0 %}
-        (select value from string_split({{ string_text }}, {{ delimiter_text }}, 1) where ordinal = {{ part_number }})
+    WITH SplitData AS (
+        SELECT value,
+        {% if part_number > 0 %}
+            , ROW_NUMBER() OVER (ORDER BY ordinal ASC) AS forward_index
+        {% else %}
+            , ROW_NUMBER() OVER (ORDER BY ordinal DESC) AS backward_index
+        {% endif %}
+        FROM string_split({{ string_text }}, {{ delimiter_text }}, 1)
+    )
+    SELECT value
+    FROM SplitData
+    WHERE
+    {% if part_number > 0 %}
+        forward_index = {{ part_number }}
     {% else %}
-        (select value from string_split({{ string_text }}, {{ delimiter_text }}, 1)
-        where ordinal = len(replace({{ string_text }}, {{delimiter_text}}, '')) + 1 + {{ part_number }})
+        backward_index = {{ abs(part_number) }}
     {% endif %}
 {% endmacro %}