Skip to content

Clarify meaning of completion trigger characters #547

@osiewicz

Description

@osiewicz

Hi,
completion trigger characters are defined as follows:

 /**
   * The set of characters that should trigger completion in a REPL. If not
   * specified, the UI should assume the `.` character.
   */
  completionTriggerCharacters?: string[];

Should DAP clients use only these characters to trigger a completion, or should it be interpreted in line with LSP, where completion triggers are a set of additional trigger characters? See the following excerpt from LSP:

/**
	 * The additional characters, beyond the defaults provided by the client (typically
	 * [a-zA-Z]), that should automatically trigger a completion request. For example
	 * `.` in JavaScript represents the beginning of an object property or method and is
	 * thus a good candidate for triggering a completion request.
	 *
	 * Most tools trigger a completion request automatically without explicitly
	 * requesting it using a keyboard shortcut (e.g. Ctrl+Space). Typically they
	 * do so when the user starts to type an identifier. For example if the user
	 * types `c` in a JavaScript file code complete will automatically pop up
	 * present `console` besides others as a completion item. Characters that
	 * make up identifiers don't need to be listed here.
	 */
	triggerCharacters?: string[];
**/

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions