patch: rename registernumber (#49)

Author: pelikhan

compiler/src/specgen.ts

@@ -22,7 +22,12 @@ import {
 import { jacdacDefaultSpecifications } from "./embedspecs"
 import { prelude } from "./prelude"
 import { camelize, upperCamel } from "./util"
-import { packetsToRegisters } from "../../runtime/jacdac-c/jacdac/spectool/jdutils"
+
+const REGISTER_NUMBER = "RegisterNumber"
+const REGISTER_BOOL = "RegisterBool"
+const REGISTER_STRING = "RegisterString"
+const REGISTER_BUFFER = "RegisterBuffer"
+const REGISTER_ARRAY = "RegisterArray"
 
 function isRegister(k: jdspec.PacketKind) {
     return k == "ro" || k == "rw" || k == "const"
@@ -114,18 +119,18 @@ function specToDeviceScript(info: jdspec.ServiceSpec): string {
         if (isRegister(pkt.kind)) {
             kw = "readonly "
             if (cmt.needsStruct) {
-                tp = `RegisterArray`
+                tp = REGISTER_ARRAY
                 if (pkt.fields.length > 1) tp += ` & { ${fields} }`
             } else {
                 if (pkt.fields.length == 1 && pkt.fields[0].type == "string")
-                    tp = "RegisterString"
+                    tp = REGISTER_STRING
                 else if (
                     pkt.fields.length == 1 &&
                     pkt.fields[0].type == "bytes"
                 )
-                    tp = "RegisterBuffer"
-                else if (pkt.fields[0].type == "bool") tp = "RegisterBool"
-                else tp = "RegisterNum"
+                    tp = REGISTER_BUFFER
+                else if (pkt.fields[0].type == "bool") tp = REGISTER_BOOL
+                else tp = REGISTER_NUMBER
             }
         } else if (pkt.kind == "event") {
             kw = "readonly "
@@ -277,19 +282,19 @@ ${varname}.${camelize(pkt.name)}(${fields}): void
         const isConst = pkt.kind === "const"
         let tp: string = undefined
         if (cmt.needsStruct) {
-            tp = `RegisterArray`
+            tp = REGISTER_ARRAY
             if (pkt.fields.length > 1) tp += ` & { ${fields} }`
         } else {
             if (pkt.fields.length == 1 && pkt.fields[0].type == "string")
-                tp = "RegisterString"
+                tp = REGISTER_STRING
             else if (pkt.fields.length == 1 && pkt.fields[0].type == "bytes")
-                tp = "RegisterBuffer"
-            else if (pkt.fields[0].type == "bool") tp = "RegisterBool"
-            else tp = "RegisterNum"
+                tp = REGISTER_BUFFER
+            else if (pkt.fields[0].type == "bool") tp = REGISTER_BOOL
+            else tp = REGISTER_NUMBER
         }
-        const isNumber = tp === "RegisterNum"
-        const isBoolean = tp === "RegisterBool"
-        const isString = tp === "RegisterString"
+        const isNumber = tp === REGISTER_NUMBER
+        const isBoolean = tp === REGISTER_BOOL
+        const isString = tp === REGISTER_STRING
         r.push(
             `### ${pname}
 `,

devs/lib/devicescript-core.d.ts

@@ -11,7 +11,7 @@ declare module "@devicescript/core" {
 
     export class Register extends PacketInfo {}
 
-    export class RegisterNum extends Register {
+    export class RegisterNumber extends Register {
         read(): number
         write(v: number): void
         onChange(threshold: number, handler: (curr: number) => void): void