Merge pull request #433 from microsoft/psl-bug-17683

fix: Document gets generated without title, if title is not added pre-export.

Author: Avijit-Microsoft

src/frontend/src/pages/draft/Draft.test.tsx

@@ -124,6 +124,13 @@ describe('Draft Component', () => {
       isLoadedSections: [{ title: 'Section 1', content: 'Content of section 1' },
       { title: 'Section 2', content: 'Content of section 2.' }
       ],
+      draftedDocument: {
+        sections: [
+          { title: 'Section 1', content: 'Content of section 1' },
+          { title: 'Section 2', content: 'Content of section 2.' }
+        ]
+      },
+      draftedDocumentTitle: '', // this must be explicitly ''
     }
     renderComponent(mockStateWithIncompleteLoad)
     await waitFor(() => {
@@ -139,6 +146,13 @@ describe('Draft Component', () => {
       isLoadedSections: [{ title: 'Section 1', content: 'Content of section 1' },
       { title: 'Section 2', content: 'Content of section 2.' }
       ], 
+      draftedDocument: {
+        sections: [
+          { title: 'Section 1', content: 'Content of section 1' },
+          { title: 'Section 2', content: 'Content of section 2.' }
+        ]
+      },
+      draftedDocumentTitle: '', // critical for button to be enabled
     }
     renderComponent(mockStateWithIncompleteLoad)
 
@@ -231,6 +245,13 @@ describe('Draft Component', () => {
       isLoadedSections: [{ title: 'Section 1', content: 'Content of section 1' },
       { title: 'Section 2', content: 'Content of section 2.' }
       ], // One section not loaded
+      draftedDocument: {
+        sections: [
+          { title: 'Section 1', content: 'Content of section 1' },
+          { title: 'Section 2', content: 'Content of section 2.' }
+        ]
+      },
+      draftedDocumentTitle: '', // must be empty string
     }
     renderComponent(mockStateWithIncompleteLoad)
 
@@ -253,7 +274,13 @@ describe('Draft Component', () => {
       isLoadedSections: [{ title: 'Section 1', content: 'Content of section 1' },
       { title: 'Section 2', content: 'Content of section 2.' }
       ],
-      draftedDocumentTitle: null
+      draftedDocument: {
+        sections: [
+          { title: 'Section 1', content: 'Content of section 1' },
+          { title: 'Section 2', content: 'Content of section 2.' }
+        ]
+      },
+      draftedDocumentTitle: null // allow null here
     }
     renderComponent(mockStateWithIncompleteLoad)
     await waitFor(async () => {

src/frontend/src/pages/draft/Draft.tsx

@@ -1,4 +1,4 @@
-import { useContext, useEffect, useState } from 'react'
+import { useContext, useEffect, useMemo, useState } from 'react'
 import styles from './Draft.module.css'
 import { useLocation, useNavigate } from 'react-router-dom'
 import TitleCard from '../../components/DraftCards/TitleCard'
@@ -16,6 +16,8 @@ const Draft = (): JSX.Element => {
 
   // get draftedDocument from context
   const draftedDocument = appStateContext?.state.draftedDocument
+  const currentChat = appStateContext?.state.currentChat
+  const draftedDocumentTitle = appStateContext?.state.draftedDocumentTitle;
   const sections = draftedDocument?.sections ?? []
 
   const isLoadedSections = appStateContext?.state.isLoadedSections
@@ -27,7 +29,9 @@ const Draft = (): JSX.Element => {
 
   const [isExportButtonDisable, setIsExportButtonDisable] = useState<boolean>(false)
 
-
+  useMemo(() => {
+      currentChat?.title && appStateContext?.dispatch({ type: 'UPDATE_DRAFTED_DOCUMENT_TITLE', payload: currentChat.title })
+  }, [currentChat?.title])
 
   useEffect(() => {
     sections.forEach((item, index) => {
@@ -45,13 +49,14 @@ const Draft = (): JSX.Element => {
 
 
   useEffect(() => {
-    if (isLoadedSections?.length === sections.length) {
+    const title = draftedDocumentTitle ?? '' // Normalize null to ''
+    if (isLoadedSections?.length === sections.length && title === '') {
       setIsExportButtonDisable(false);
     }
     else {
       setIsExportButtonDisable(true);
     }
-  }, [isLoadedSections])
+  }, [isLoadedSections, draftedDocumentTitle])
 
 
   if (!draftedDocument) {