Skip to content

Commit 9f3452a

Browse files
Merge pull request #294 from microsoft/update-tags
fix: updated baseurl and imageTag in bicep
2 parents 93558c0 + f32c48b commit 9f3452a

File tree

4 files changed

+16
-15
lines changed

4 files changed

+16
-15
lines changed

.github/workflows/deploy.yml

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -111,16 +111,17 @@ jobs:
111111
set -e
112112
az deployment group create \
113113
--resource-group ${{ env.RESOURCE_GROUP_NAME }} \
114-
--template-file infrastructure/deployment.json \
114+
--template-file infra/main.json \
115115
--parameters \
116-
HostingPlanName="${{ env.SOLUTION_PREFIX }}-plan" \
117-
ApplicationInsightsName="appins-${{ env.SOLUTION_PREFIX }}" \
118-
WebsiteName="webapp-${{ env.SOLUTION_PREFIX }}" \
119-
CosmosDBName="db-cosmos-${{ env.SOLUTION_PREFIX }}" \
120-
CosmosDBRegion="${{ env.AZURE_LOCATION }}" \
121-
AzureSearchService="search-${{ env.SOLUTION_PREFIX }}" \
122-
AzureOpenAIResource="aoai-${{ env.SOLUTION_PREFIX }}" \
123-
WorkspaceName="worksp-${{ env.SOLUTION_PREFIX }}"
116+
environmentName="${{ env.SOLUTION_PREFIX }}" \
117+
secondaryLocation="eastus2" \
118+
deploymentType="Standard" \
119+
gptModelName="gpt-4" \
120+
azureOpenaiAPIVersion="2024-05-01-preview" \
121+
gptDeploymentCapacity="10" \
122+
embeddingModel="text-embedding-ada-002" \
123+
embeddingDeploymentCapacity="30" \
124+
imageTag="latest"
124125
125126
- name: Delete Bicep Deployment
126127
if: success()

.github/workflows/node.js.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ jobs:
1818
working-directory: frontend
1919
strategy:
2020
matrix:
21-
node-version: [16.x, 18.x, 21.x]
21+
node-version: [18.x, 21.x]
2222
# See supported Node.js release schedule at https://nodejs.org/en/about/releases/
2323

2424
steps:

infra/main.bicep

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,14 +55,14 @@ param embeddingModel string = 'text-embedding-ada-002'
5555
@description('Capacity of the Embedding Model deployment')
5656
param embeddingDeploymentCapacity int = 80
5757

58-
param imageTag string = 'dev'
58+
param imageTag string = 'latest'
5959

6060
var uniqueId = toLower(uniqueString(environmentName, subscription().id, resourceGroup().location))
6161
var solutionPrefix = 'dg${padLeft(take(uniqueId, 12), 12, '0')}'
6262
var resourceGroupLocation = resourceGroup().location
6363

6464
var solutionLocation = resourceGroupLocation
65-
var baseUrl = 'https://raw.githubusercontent.com/microsoft/Generic-Build-your-own-copilot-Solution-Accelerator/dev/'
65+
var baseUrl = 'https://raw.githubusercontent.com/microsoft/Generic-Build-your-own-copilot-Solution-Accelerator/main/'
6666

6767
var ApplicationInsightsName = 'appins-${solutionPrefix}'
6868
var WorkspaceName = 'worksp-${solutionPrefix}'

infra/main.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
"_generator": {
66
"name": "bicep",
77
"version": "0.33.93.31351",
8-
"templateHash": "4863966964832108128"
8+
"templateHash": "15906054451527240113"
99
}
1010
},
1111
"parameters": {
@@ -84,15 +84,15 @@
8484
},
8585
"imageTag": {
8686
"type": "string",
87-
"defaultValue": "dev"
87+
"defaultValue": "latest"
8888
}
8989
},
9090
"variables": {
9191
"uniqueId": "[toLower(uniqueString(parameters('environmentName'), subscription().id, resourceGroup().location))]",
9292
"solutionPrefix": "[format('dg{0}', padLeft(take(variables('uniqueId'), 12), 12, '0'))]",
9393
"resourceGroupLocation": "[resourceGroup().location]",
9494
"solutionLocation": "[variables('resourceGroupLocation')]",
95-
"baseUrl": "https://raw.githubusercontent.com/microsoft/Generic-Build-your-own-copilot-Solution-Accelerator/dev/",
95+
"baseUrl": "https://raw.githubusercontent.com/microsoft/Generic-Build-your-own-copilot-Solution-Accelerator/main/",
9696
"ApplicationInsightsName": "[format('appins-{0}', variables('solutionPrefix'))]",
9797
"WorkspaceName": "[format('worksp-{0}', variables('solutionPrefix'))]"
9898
},

0 commit comments

Comments
 (0)