Update framework pipeline

Author: lbussell

eng/pipelines/dotnet-framework.yml

@@ -1,13 +1,6 @@
 trigger: none
 pr: none
 
-resources:
-  repositories:
-  - repository: VersionsRepo
-    type: github
-    endpoint: dotnet
-    name: dotnet/versions
-
 parameters:
 - name: sourceBuildPipelineRunId
   displayName: >
@@ -17,32 +10,45 @@ parameters:
     building new images, leave this value alone.
   type: string
   default: $(Build.BuildId)
+- name: noCache
+  displayName: >
+    Run build with no cache. When this is unchecked, the build will use the
+    info in the dotnet/versions repo to build only the images which have had
+    Dockerfile changes or base images updates. When this is checked, all images
+    will be built regardless of caching status.
+  type: boolean
+  default: false
 
 variables:
 - template: /eng/pipelines/variables/common.yml@self
-  parameters:
-    sourceBuildPipelineRunId: ${{ parameters.sourceBuildPipelineRunId }}
-- template: /eng/common/templates/variables/dotnet/secrets.yml@self
+- template: /eng/common/templates/variables/dotnet/secrets${{ iif(contains(variables['Build.DefinitionName'], '-official'), '', '-unofficial') }}.yml@self
 - name: manifest
   value: manifest.json
 - name: mcrImageIngestionTimeout
   value: "00:30:00"
 
+resources:
+  repositories:
+  - repository: VersionsRepo
+    type: github
+    endpoint: dotnet
+    name: dotnet/versions
+
 extends:
-  template: /eng/common/templates/1es-official.yml@self
+  template: /eng/common/templates/1es.yml@self
   parameters:
-    serviceConnections:
-    - name: $(internal-mirror.serviceConnectionName)
-    - name: $(build.serviceConnectionName)
-    - name: $(publish.serviceConnectionName)
-    - name: $(kusto.serviceConnectionName)
-    - name: $(marStatus.serviceConnectionName)
+    reposToExcludeFromScanning:
+    - VersionsRepo
     stages:
-    - template: /eng/common/templates/stages/dotnet/build-test-publish-repo.yml@self
+    - template: /eng/common/templates/stages/dotnet/publish-config-${{ iif(contains(variables['Build.DefinitionName'], '-official'), 'prod', 'nonprod') }}.yml@self
       parameters:
-        internalProjectName: ${{ variables.internalProjectName }}
-        publicProjectName: ${{ variables.publicProjectName }}
-        versionsRepoRef: VersionsRepo
         sourceBuildPipelineRunId: ${{ parameters.sourceBuildPipelineRunId }}
-        windowsAmdBuildJobTimeout: 240
-        windowsAmdTestJobTimeout: 90
+        stagesTemplate: /eng/pipelines/stages/dotnet-framework-base.yml@self
+        stagesTemplateParameters:
+          versionsRepoRef: VersionsRepo
+          sourceBuildPipelineRunId: ${{ parameters.sourceBuildPipelineRunId }}
+          noCache: ${{ parameters.noCache }}
+          ${{ if contains(variables['Build.DefinitionName'], '-official') }}:
+            additionalServiceConnections:
+            - name: $(kusto.serviceConnectionName)
+            - name: $(marStatus.serviceConnectionName)

eng/pipelines/stages/dotnet-framework-base.yml

@@ -0,0 +1,46 @@
+parameters:
+- name: publishConfig
+  type: object
+- name: internalProjectName
+  type: string
+- name: publicProjectName
+  type: string
+
+- name: sourceBuildPipelineRunId
+  type: string
+  default: $(Build.BuildId)
+- name: versionsRepoRef
+  type: string
+  default: ""
+- name: noCache
+  type: boolean
+  default: false
+- name: windowsAmdBuildJobTimeout
+  default: 240
+- name: windowsAmdTestJobTimeout
+  default: 90
+# Additional service connections needed by this pipeline that are not included
+# in the publishConfig.
+- name: additionalServiceConnections
+  type: object
+  default: []
+
+
+stages:
+- ${{ if ne(variables['Build.Reason'], 'PullRequest') }}:
+  - template: /eng/common/templates/stages/setup-service-connections.yml@self
+    parameters:
+      serviceConnections:
+      - name: ${{ parameters.publishConfig.internalMirrorAcr.serviceConnection.name }}
+      - name: ${{ parameters.publishConfig.buildAcr.serviceConnection.name }}
+      - name: ${{ parameters.publishConfig.publishAcr.serviceConnection.name }}
+      - ${{ each serviceConnection in parameters.additionalServiceConnections }}:
+        - name: ${{ serviceConnection.name }}
+
+- template: /eng/common/templates/stages/dotnet/build-test-publish-repo.yml@self
+  parameters:
+    versionsRepoRef: ${{ parameters.versionsRepoRef }}
+    sourceBuildPipelineRunId: ${{ parameters.sourceBuildPipelineRunId }}
+    noCache: ${{ parameters.noCache }}
+    windowsAmdBuildJobTimeout: ${{ parameters.windowsAmdBuildJobTimeout }}
+    windowsAmdTestJobTimeout: ${{ parameters.windowsAmdTestJobTimeout }}

eng/pipelines/variables/common.yml

@@ -1,25 +1,52 @@
-parameters:
-# sourceBuildPipelineRunId should be overridden when skipping a build to run
-# tests or publish images that were produced in a different pipeline run.
-- name: sourceBuildPipelineRunId
-  type: string
-  default: ""
-
 variables:
 - template: /eng/common/templates/variables/dotnet/build-test-publish.yml@self
-  parameters:
-    sourceBuildPipelineRunId: ${{ parameters.sourceBuildPipelineRunId }}
-- name: publicGitRepoUri
-  value: https://github.com/microsoft/dotnet-framework-docker
-- name: productVersionComponents
+
+- name: "publicGitRepoUri"
+  value: "https://github.com/microsoft/dotnet-framework-docker"
+
+- name: "productVersionComponents"
   value: 3
-- name: testScriptPath
-  value: ./tests/run-tests.ps1
-- name: testResultsDirectory
-  value: tests/Microsoft.DotNet.Framework.Docker.Tests/TestResults/
-- name: publicSourceBranch
-  value: main
-- name: additionalPublishMcrDocsArgs
+
+- name: "testScriptPath"
+  value: "./tests/run-tests.ps1"
+- name: "testResultsDirectory"
+  value: "tests/Microsoft.DotNet.Framework.Docker.Tests/TestResults/"
+
+# .NET Framework images only publish from one branch
+- name: "publicSourceBranch"
+  value: "main"
+  readonly: true
+
+- name: "additionalPublishMcrDocsArgs"
   value: "--root /repo/.portal-docs"
-- name: publishEolAnnotations
-  value: true
+
+- ${{ if contains(variables['Build.DefinitionName'], '-official') }}:
+  - name: "publishEolAnnotations"
+    value: true
+
+- ${{ else }}:
+  # Disable EOL annotations for unofficial build
+  - name: "publishEolAnnotations"
+    value: false
+    readonly: true
+
+  # Unofficial secrets group has no GitHub token for publishing image info, notifications, or readmes
+  - name: "publishImageInfo"
+    value: false
+    readonly: true
+  - name: "publishNotificationsEnabled"
+    value: false
+    readonly: true
+  - name: "publishReadme"
+    value: false
+    readonly: true
+
+  # There aren't test/unofficial Kusto tables for build telemetry yet
+  - name: "ingestKustoImageInfo"
+    value: false
+    readonly: true
+
+  # Always run unofficial pipelines in debug mode
+  - name: "System.Debug"
+    value: true
+    readonly: true