From c9310fa50de6731461e2889305807a4106647e03 Mon Sep 17 00:00:00 2001 From: Michael Simons Date: Wed, 2 Oct 2024 09:51:04 -0500 Subject: [PATCH 1/4] Switch to using linkspector for validating markdown links --- .github/linters/.check-markdown-links.json | 16 ---------------- .github/linters/.linkspector.yml | 11 +++++++++++ .github/workflows/check-markdown-links.yml | 8 ++++---- 3 files changed, 15 insertions(+), 20 deletions(-) delete mode 100644 .github/linters/.check-markdown-links.json create mode 100644 .github/linters/.linkspector.yml diff --git a/.github/linters/.check-markdown-links.json b/.github/linters/.check-markdown-links.json deleted file mode 100644 index c3789718..00000000 --- a/.github/linters/.check-markdown-links.json +++ /dev/null @@ -1,16 +0,0 @@ -{ - "ignorePatterns": [ - { - "pattern": "^https://dotnetbinaries.blob.core.windows.net/dockerassets" - }, - { - "pattern": "^https://github.com/dotnet/release/blob/main/.github/ISSUE_TEMPLATE/dotnet-fx-docker-servicing-release.md" - }, - { - "pattern": "^https://mcr.microsoft.com/v2/\\{\\{REPO\\}\\}/tags/list" - }, - { - "pattern": "^https://github.com/microsoft/dotnet-framework-docker/blob/main/README.\\{\\{SHORT_REPO\\}\\}.md#full-tag-listing" - } - ] -} diff --git a/.github/linters/.linkspector.yml b/.github/linters/.linkspector.yml new file mode 100644 index 00000000..5cdeea22 --- /dev/null +++ b/.github/linters/.linkspector.yml @@ -0,0 +1,11 @@ +aliveStatusCodes: + - 200 + - 406 +dirs: + - . + - .github +excludedDirs: + - eng/readme-templates +ignorePatterns: + - pattern: "^https://github.com/dotnet/release/blob/main/.github/ISSUE_TEMPLATE/dotnet-fx-docker-servicing-release.md" +useGitIgnore: true diff --git a/.github/workflows/check-markdown-links.yml b/.github/workflows/check-markdown-links.yml index 225f3ed8..681caf35 100644 --- a/.github/workflows/check-markdown-links.yml +++ b/.github/workflows/check-markdown-links.yml @@ -17,8 +17,8 @@ jobs: uses: actions/checkout@v4 - name: Check markdown links - uses: gaurav-nelson/github-action-markdown-link-check@v1 + uses: umbrelladocs/action-linkspector@v1 with: - config-file: .github/linters/.check-markdown-links.json - use-quiet-mode: 'yes' - use-verbose-mode: 'no' + config_file: .github/linters/.linkspector.yml + fail_on_error: true + filter_mode: nofilter From 70643dc88adfc738602ff473a46e0cafac968f6c Mon Sep 17 00:00:00 2001 From: Michael Simons Date: Wed, 2 Oct 2024 09:53:44 -0500 Subject: [PATCH 2/4] Modify md file to trigger action --- SECURITY.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/SECURITY.md b/SECURITY.md index 1fd696a7..268b688c 100644 --- a/SECURITY.md +++ b/SECURITY.md @@ -9,3 +9,5 @@ The .NET Framework support policy, including supported versions, can be found at Security issues and bugs should be reported privately to the Microsoft Security Response Center (MSRC), either by emailing or via the [Microsoft Security Response Center](https://msrc.microsoft.com). You should receive a response within 24 hours. If for some reason you do not, please follow up via email to ensure we received your original message. Further information, including the MSRC PGP key, can be found in the [MSRC Report an Issue FAQ](https://www.microsoft.com/en-us/msrc/faqs-report-an-issue). Please do not open issues for anything you think might have a security implication. + +testing only change \ No newline at end of file From da6ea8367746f2ab8dea13f3ba468f331c1048a4 Mon Sep 17 00:00:00 2001 From: Michael Simons Date: Wed, 2 Oct 2024 09:59:03 -0500 Subject: [PATCH 3/4] Add ignore --- .github/linters/.linkspector.yml | 1 + SECURITY.md | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/linters/.linkspector.yml b/.github/linters/.linkspector.yml index 5cdeea22..d69ed7ca 100644 --- a/.github/linters/.linkspector.yml +++ b/.github/linters/.linkspector.yml @@ -7,5 +7,6 @@ dirs: excludedDirs: - eng/readme-templates ignorePatterns: + - pattern: "^https://dotnetbinaries.blob.core.windows.net/dockerassets" - pattern: "^https://github.com/dotnet/release/blob/main/.github/ISSUE_TEMPLATE/dotnet-fx-docker-servicing-release.md" useGitIgnore: true diff --git a/SECURITY.md b/SECURITY.md index 268b688c..53fab371 100644 --- a/SECURITY.md +++ b/SECURITY.md @@ -10,4 +10,4 @@ Security issues and bugs should be reported privately to the Microsoft Security Please do not open issues for anything you think might have a security implication. -testing only change \ No newline at end of file +testing only change From 12b9669f08d7e8a9b30fb8c8bd5418793d326e61 Mon Sep 17 00:00:00 2001 From: Michael Simons Date: Wed, 2 Oct 2024 10:06:12 -0500 Subject: [PATCH 4/4] Revert testing change --- SECURITY.md | 2 -- 1 file changed, 2 deletions(-) diff --git a/SECURITY.md b/SECURITY.md index 53fab371..1fd696a7 100644 --- a/SECURITY.md +++ b/SECURITY.md @@ -9,5 +9,3 @@ The .NET Framework support policy, including supported versions, can be found at Security issues and bugs should be reported privately to the Microsoft Security Response Center (MSRC), either by emailing or via the [Microsoft Security Response Center](https://msrc.microsoft.com). You should receive a response within 24 hours. If for some reason you do not, please follow up via email to ensure we received your original message. Further information, including the MSRC PGP key, can be found in the [MSRC Report an Issue FAQ](https://www.microsoft.com/en-us/msrc/faqs-report-an-issue). Please do not open issues for anything you think might have a security implication. - -testing only change