Skip to content

Commit dac6936

Browse files
committed
Fix poor naming in connectors
1 parent 2522c1e commit dac6936

File tree

4 files changed

+21
-9
lines changed

4 files changed

+21
-9
lines changed

text_2_sql/text_2_sql_core/src/text_2_sql_core/connectors/factory.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,9 @@ def get_database_connector():
2222

2323
return SnowflakeSqlConnector()
2424
elif os.environ["Text2Sql__DatabaseEngine"].upper() == "TSQL":
25-
from text_2_sql_core.connectors.tsql_sql import TSQLSqlConnector
25+
from text_2_sql_core.connectors.tsql_sql import TsqlSqlConnector
2626

27-
return TSQLSqlConnector()
27+
return TsqlSqlConnector()
2828
elif os.environ["Text2Sql__DatabaseEngine"].upper() == "POSTGRESQL":
2929
from text_2_sql_core.connectors.postgresql_sql import (
3030
PostgresqlSqlConnector,

text_2_sql/text_2_sql_core/src/text_2_sql_core/connectors/tsql_sql.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
from text_2_sql_core.utils.database import DatabaseEngine, DatabaseEngineSpecificFields
1111

1212

13-
class TSQLSqlConnector(SqlConnector):
13+
class TsqlSqlConnector(SqlConnector):
1414
def __init__(self):
1515
super().__init__()
1616

text_2_sql/text_2_sql_core/src/text_2_sql_core/data_dictionary/cli.py

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,12 +83,24 @@ def create(
8383
)
8484
elif engine == DatabaseEngine.TSQL:
8585
from text_2_sql_core.data_dictionary.tsql_data_dictionary_creator import (
86-
TSQLDataDictionaryCreator,
86+
TsqlDataDictionaryCreator,
8787
)
8888

89-
data_dictionary_creator = TSQLDataDictionaryCreator(
89+
data_dictionary_creator = TsqlDataDictionaryCreator(
9090
**kwargs,
9191
)
92+
elif engine == DatabaseEngine.POSTGRESQL:
93+
from text_2_sql_core.data_dictionary.postgresql_data_dictionary_creator import (
94+
PostgresqlDataDictionaryCreator,
95+
)
96+
97+
data_dictionary_creator = PostgresqlDataDictionaryCreator(
98+
**kwargs,
99+
)
100+
else:
101+
raise NotImplementedError(
102+
f"Data Dictionary Creator for {engine.value} is not implemented."
103+
)
92104
except ImportError:
93105
detailed_error = f"""Failed to import {
94106
engine.value} Data Dictionary Creator. Check you have installed the optional dependencies for this database engine."""

text_2_sql/text_2_sql_core/src/text_2_sql_core/data_dictionary/tsql_data_dictionary_creator.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,10 @@
77
import asyncio
88
import os
99
from text_2_sql_core.utils.database import DatabaseEngine
10-
from text_2_sql_core.connectors.tsql_sql import TSQLSqlConnector
10+
from text_2_sql_core.connectors.tsql_sql import TsqlSqlConnector
1111

1212

13-
class TSQLDataDictionaryCreator(DataDictionaryCreator):
13+
class TsqlDataDictionaryCreator(DataDictionaryCreator):
1414
def __init__(self, **kwargs):
1515
"""A method to initialize the DataDictionaryCreator class.
1616
@@ -25,7 +25,7 @@ def __init__(self, **kwargs):
2525

2626
self.database_engine = DatabaseEngine.TSQL
2727

28-
self.sql_connector = TSQLSqlConnector()
28+
self.sql_connector = TsqlSqlConnector()
2929

3030
"""A class to extract data dictionary information from a SQL Server database."""
3131

@@ -115,5 +115,5 @@ def extract_entity_relationships_sql_query(self) -> str:
115115

116116

117117
if __name__ == "__main__":
118-
data_dictionary_creator = TSQLDataDictionaryCreator()
118+
data_dictionary_creator = TsqlDataDictionaryCreator()
119119
asyncio.run(data_dictionary_creator.create_data_dictionary())

0 commit comments

Comments
 (0)