partial fb addressed

Author: YunchuWang

samples/ScheduleConsoleApp/Orchestrators/StockPriceOrchestrator.cs

@@ -14,7 +14,7 @@ public override async Task<string> RunAsync(TaskOrchestrationContext context, st
         try
         {
             // Get current stock price
-            decimal currentPrice = await context.CallActivityAsync<decimal>("GetStockPrice", symbol);
+            decimal currentPrice = await context.CallGetStockPriceAsync(symbol);
 
             logger.LogInformation("Current price for {symbol} is ${price:F2}", symbol, currentPrice);
 

samples/ScheduleConsoleApp/Program.cs

@@ -25,14 +25,14 @@
 
             // Enable scheduled tasks support
             builder.UseDurableTaskScheduler(connectionString);
-            builder.EnableScheduledTasksSupport();
+            builder.UseScheduledTasks();
         });
 
         // Configure the client
         services.AddDurableTaskClient(builder =>
         {
             builder.UseDurableTaskScheduler(connectionString);
-            builder.EnableScheduledTasksSupport();
+            builder.UseScheduledTasks();
         });
 
         // Configure console logging
@@ -62,28 +62,15 @@
     AsyncPageable<string> schedules = await scheduledTaskClient.ListScheduleIdsAsync(query);
 
     // Initialize the continuation token
-    string? continuationToken = null;
-    await foreach (Page<string> page in schedules.AsPages(continuationToken))
+    await foreach (string scheduleId in schedules)
     {
-        foreach (string scheduleId in page.Values)
-        {
-            // Obtain the schedule handle for the current scheduleId
-            IScheduleHandle handle = scheduledTaskClient.GetScheduleHandle(scheduleId);
-
-            // Delete the schedule
-            await handle.DeleteAsync();
+        // Obtain the schedule handle for the current scheduleId
+        IScheduleHandle handle = scheduledTaskClient.GetScheduleHandle(scheduleId);
 
-            Console.WriteLine($"Deleted schedule {scheduleId}");
-        }
+        // Delete the schedule
+        await handle.DeleteAsync();
 
-        // Update the continuation token for the next iteration
-        continuationToken = page.ContinuationToken;
-
-        // If there's no continuation token, we've reached the end of the collection
-        if (continuationToken == null)
-        {
-            break;
-        }
+        Console.WriteLine($"Deleted schedule {scheduleId}");
     }
 
 
@@ -101,7 +88,7 @@
     ScheduleDescription scheduleDescription = await scheduleHandle.DescribeAsync();
 
     // print the schedule description
-    Console.WriteLine(scheduleDescription.ToJsonString(true));
+    Console.WriteLine(scheduleDescription);
 
     Console.WriteLine("");
     Console.WriteLine("");
@@ -111,7 +98,7 @@
     Console.WriteLine("\nPausing schedule...");
     await scheduleHandle.PauseAsync();
     scheduleDescription = await scheduleHandle.DescribeAsync();
-    Console.WriteLine(scheduleDescription.ToJsonString(true));
+    Console.WriteLine(scheduleDescription);
     Console.WriteLine("");
     Console.WriteLine("");
     Console.WriteLine("");
@@ -121,15 +108,13 @@
     Console.WriteLine("\nResuming schedule...");
     await scheduleHandle.ResumeAsync();
     scheduleDescription = await scheduleHandle.DescribeAsync();
-    Console.WriteLine(scheduleDescription.ToJsonString(true));
+    Console.WriteLine(scheduleDescription);
 
     Console.WriteLine("");
     Console.WriteLine("");
     Console.WriteLine("");
 
     await Task.Delay(TimeSpan.FromMinutes(30));
-    //Console.WriteLine("\nPress any key to delete the schedule and exit...");
-    //Console.ReadKey();
 }
 catch (Exception ex)
 {

samples/ScheduleWebApp/Program.cs

@@ -23,14 +23,14 @@
         r.AddOrchestrator<CacheClearingOrchestrator>();
     });
     builder.UseDurableTaskScheduler(connectionString);
-    builder.EnableScheduledTasksSupport();
+    builder.UseScheduledTasks();
 });
 
 // Register the client, which can be used to start orchestrations
 builder.Services.AddDurableTaskClient(builder =>
 {
     builder.UseDurableTaskScheduler(connectionString);
-    builder.EnableScheduledTasksSupport();
+    builder.UseScheduledTasks();
 });
 
 // Configure console logging using the simpler, more compact format

samples/ScheduleWebApp/Properties/launchSettings.json

@@ -15,7 +15,7 @@
       "dotnetRunMessages": true,
       "environmentVariables": {
         "ASPNETCORE_ENVIRONMENT": "Development",
-        "DURABLE_TASK_SCHEDULER_CONNECTION_STRING": "Endpoint=https://wbtestschedule01-g7fvgkfhe4ac.eastus2euap.durabletask.io;TaskHub=wbtestschedule01th01;Authentication=DefaultAzure"
+        "DURABLE_TASK_SCHEDULER_CONNECTION_STRING": "<your-connection-string>"
       }
     }
   }

src/ScheduledTasks/Client/ScheduledTaskClient.cs

@@ -11,21 +11,10 @@ namespace Microsoft.DurableTask.ScheduledTasks;
 /// <summary>
 /// Client for managing scheduled tasks in a Durable Task application.
 /// </summary>
-public class ScheduledTaskClient : IScheduledTaskClient
+public class ScheduledTaskClient(DurableTaskClient durableTaskClient, ILogger logger) : IScheduledTaskClient
 {
-    readonly DurableTaskClient durableTaskClient;
-    readonly ILogger logger;
-
-    /// <summary>
-    /// Initializes a new instance of the <see cref="ScheduledTaskClient"/> class.
-    /// </summary>
-    /// <param name="durableTaskClient">The Durable Task client to use for orchestration operations.</param>
-    /// <param name="logger">logger.</param>
-    public ScheduledTaskClient(DurableTaskClient durableTaskClient, ILogger logger)
-    {
-        this.durableTaskClient = Check.NotNull(durableTaskClient, nameof(durableTaskClient));
-        this.logger = Check.NotNull(logger, nameof(logger));
-    }
+    readonly DurableTaskClient durableTaskClient = Check.NotNull(durableTaskClient, nameof(durableTaskClient));
+    readonly ILogger logger = Check.NotNull(logger, nameof(logger));
 
     /// <inheritdoc/>
     public async Task<ScheduleHandle> CreateScheduleAsync(ScheduleCreationOptions creationOptions, CancellationToken cancellation = default)

src/ScheduledTasks/Exception/ScheduleAlreadyExistException.cs

@@ -6,7 +6,7 @@ namespace Microsoft.DurableTask.ScheduledTasks;
 /// <summary>
 /// Exception thrown when attempting to create a schedule with an ID that already exists.
 /// </summary>
-public class ScheduleAlreadyExistException : Exception
+public class ScheduleAlreadyExistException : InvalidOperationException
 {
     /// <summary>
     /// Initializes a new instance of the <see cref="ScheduleAlreadyExistException"/> class.

src/ScheduledTasks/Exception/ScheduleClientValidationException.cs

@@ -6,7 +6,7 @@ namespace Microsoft.DurableTask.ScheduledTasks;
 /// <summary>
 /// Exception thrown when client-side validation fails for schedule operations.
 /// </summary>
-public class ScheduleClientValidationException : Exception
+public class ScheduleClientValidationException : InvalidOperationException
 {
     /// <summary>
     /// Initializes a new instance of the <see cref="ScheduleClientValidationException"/> class.

src/ScheduledTasks/Exception/ScheduleInvalidTransitionException.cs

@@ -6,7 +6,7 @@ namespace Microsoft.DurableTask.ScheduledTasks;
 /// <summary>
 /// Exception thrown when an invalid state transition is attempted on a schedule.
 /// </summary>
-public class ScheduleInvalidTransitionException : Exception
+public class ScheduleInvalidTransitionException : InvalidOperationException
 {
     /// <summary>
     /// Initializes a new instance of the <see cref="ScheduleInvalidTransitionException"/> class.

src/ScheduledTasks/Exception/ScheduleNotFoundException.cs

@@ -6,7 +6,7 @@ namespace Microsoft.DurableTask.ScheduledTasks;
 /// <summary>
 /// Exception thrown when attempting to access a schedule that does not exist.
 /// </summary>
-public class ScheduleNotFoundException : Exception
+public class ScheduleNotFoundException : InvalidOperationException
 {
     /// <summary>
     /// Initializes a new instance of the <see cref="ScheduleNotFoundException"/> class.

src/ScheduledTasks/Extension/DurableTaskClientBuilderExtensions.cs

@@ -13,11 +13,11 @@ namespace Microsoft.DurableTask.ScheduledTasks;
 public static class DurableTaskClientBuilderExtensions
 {
     /// <summary>
-    /// Enables scheduled task support for the client builder.
+    /// Enables scheduled tasks support for the client builder.
     /// </summary>
     /// <param name="builder">The client builder to add scheduled task support to.</param>
     /// <returns>The original builder, for call chaining.</returns>
-    public static IDurableTaskClientBuilder EnableScheduledTasksSupport(this IDurableTaskClientBuilder builder)
+    public static IDurableTaskClientBuilder UseScheduledTasks(this IDurableTaskClientBuilder builder)
     {
         builder.Services.AddTransient<IScheduledTaskClient>(sp =>
         {