Merge branch 'main' into wangbill/dedup

Author: YunchuWang

src/Analyzers/AnalyzerReleases.Shipped.md

@@ -1,6 +1,15 @@
 ; Shipped analyzer releases
 ; https://github.com/dotnet/roslyn/blob/main/src/RoslynAnalyzers/Microsoft.CodeAnalysis.Analyzers/ReleaseTrackingAnalyzers.Help.md
 
+## Release 0.2.0
+
+### New Rules
+
+Rule ID | Category | Severity | Notes
+--------|----------|----------|-------
+DURABLE2003 | Activity | Warning | **FunctionNotFoundAnalyzer**: Warns when an activity function call references a name that does not match any defined activity in the compilation.
+DURABLE2004 | Orchestration | Warning | **FunctionNotFoundAnalyzer**: Warns when a sub-orchestration call references a name that does not match any defined orchestrator in the compilation.
+
 ## Release 0.1.0
 
 ### New Rules

src/Analyzers/AnalyzerReleases.Unshipped.md

@@ -4,6 +4,4 @@
 ### New Rules
 
 Rule ID | Category | Severity | Notes
---------|----------|----------|-------
-DURABLE2003 | Activity | Warning | **FunctionNotFoundAnalyzer**: Warns when an activity function call references a name that does not match any defined activity in the compilation.
-DURABLE2004 | Orchestration | Warning | **FunctionNotFoundAnalyzer**: Warns when a sub-orchestration call references a name that does not match any defined orchestrator in the compilation.
+--------|----------|----------|-------

src/Analyzers/Analyzers.csproj

@@ -11,7 +11,7 @@
   </PropertyGroup>
 
   <PropertyGroup>
-    <VersionPrefix>0.1.0</VersionPrefix>
+    <VersionPrefix>0.2.0</VersionPrefix>
     <VersionSuffix></VersionSuffix>
     <PackageDescription>.NET Analyzers for the Durable Task SDK.</PackageDescription>
     <NeutralLanguage>en</NeutralLanguage>

test/Grpc.IntegrationTests/OrchestrationPatterns.cs

@@ -1195,6 +1195,101 @@ async Task<int> OrchestratorFunc(TaskOrchestrationContext ctx, int counter)
         Assert.Equal(EventCount, metadata.ReadOutputAs<int>());
     }
 
-    // TODO: Test for multiple external events with the same name
-    // TODO: Test for catching activity exceptions of specific types
+    [Fact]
+    public async Task CatchingActivityExceptionsByType()
+    {
+        TaskName orchestratorName = nameof(CatchingActivityExceptionsByType);
+        TaskName throwInvalidOpActivityName = "ThrowInvalidOp";
+        TaskName throwArgumentActivityName = "ThrowArgument";
+        TaskName successActivityName = "Success";
+
+        await using HostTestLifetime server = await this.StartWorkerAsync(b =>
+        {
+            b.AddTasks(tasks => tasks
+                .AddOrchestratorFunc(orchestratorName, async ctx =>
+                {
+                    List<string> results = new();
+
+                    // Test 1: Catch InvalidOperationException
+                    try
+                    {
+                        await ctx.CallActivityAsync(throwInvalidOpActivityName);
+                        results.Add("No exception thrown");
+                    }
+                    catch (TaskFailedException ex) when (ex.FailureDetails?.IsCausedBy<InvalidOperationException>() == true)
+                    {
+                        results.Add("Caught InvalidOperationException");
+                    }
+                    catch (TaskFailedException)
+                    {
+                        results.Add("Caught wrong exception type");
+                    }
+
+                    // Test 2: Catch ArgumentException
+                    try
+                    {
+                        await ctx.CallActivityAsync(throwArgumentActivityName);
+                        results.Add("No exception thrown");
+                    }
+                    catch (TaskFailedException ex) when (ex.FailureDetails?.IsCausedBy<ArgumentException>() == true)
+                    {
+                        results.Add("Caught ArgumentException");
+                    }
+                    catch (TaskFailedException)
+                    {
+                        results.Add("Caught wrong exception type");
+                    }
+
+                    // Test 3: Successful activity should not throw
+                    try
+                    {
+                        string result = await ctx.CallActivityAsync<string>(successActivityName);
+                        results.Add(result);
+                    }
+                    catch (TaskFailedException)
+                    {
+                        results.Add("Unexpected exception");
+                    }
+
+                    // Test 4: Catch with base Exception type
+                    try
+                    {
+                        await ctx.CallActivityAsync(throwInvalidOpActivityName);
+                        results.Add("No exception thrown");
+                    }
+                    catch (TaskFailedException ex) when (ex.FailureDetails?.IsCausedBy<Exception>() == true)
+                    {
+                        results.Add("Caught base Exception");
+                    }
+
+                    return results;
+                })
+                .AddActivityFunc(throwInvalidOpActivityName, (TaskActivityContext ctx) =>
+                {
+                    throw new InvalidOperationException("Invalid operation");
+                })
+                .AddActivityFunc(throwArgumentActivityName, (TaskActivityContext ctx) =>
+                {
+                    throw new ArgumentException("Invalid argument");
+                })
+                .AddActivityFunc<string>(successActivityName, (TaskActivityContext ctx) =>
+                {
+                    return "Success";
+                }));
+        });
+
+        string instanceId = await server.Client.ScheduleNewOrchestrationInstanceAsync(orchestratorName);
+        OrchestrationMetadata metadata = await server.Client.WaitForInstanceCompletionAsync(
+            instanceId, getInputsAndOutputs: true, this.TimeoutToken);
+        Assert.NotNull(metadata);
+        Assert.Equal(OrchestrationRuntimeStatus.Completed, metadata.RuntimeStatus);
+
+        List<string>? results = metadata.ReadOutputAs<List<string>>();
+        Assert.NotNull(results);
+        Assert.Equal(4, results!.Count);
+        Assert.Equal("Caught InvalidOperationException", results[0]);
+        Assert.Equal("Caught ArgumentException", results[1]);
+        Assert.Equal("Success", results[2]);
+        Assert.Equal("Caught base Exception", results[3]);
+    }
 }