Address PR comments

Author: jviau

src/Analyzers/Analyzers.csproj

@@ -2,30 +2,22 @@
 
   <PropertyGroup>
     <TargetFramework>netstandard2.0</TargetFramework>
+    <IncludeShared>false</IncludeShared>
     <IsRoslynComponent>true</IsRoslynComponent>
     <EnableStyleCop>true</EnableStyleCop>
-
-    <!-- Do not include the generator as a lib dependency -->
-    <IncludeBuildOutput>false</IncludeBuildOutput>
-    <SuppressDependenciesWhenPacking>true</SuppressDependenciesWhenPacking>
-    <IncludeShared>false</IncludeShared>
-    <GenerateDocumentationFile>true</GenerateDocumentationFile>
-    <!-- Do not publish it until it is ready to release -->
-    <IsPackable>false</IsPackable>
-  </PropertyGroup>
-
-  <PropertyGroup>
     <EnforceExtendedAnalyzerRules>true</EnforceExtendedAnalyzerRules>
-  </PropertyGroup>
-
-  <PropertyGroup>
-    <PackageDescription>.NET Analyzers for the Durable Task Framework.</PackageDescription>
+    <GenerateDocumentationFile>false</GenerateDocumentationFile>
+    <NoWarn>$(NoWarn);SA0001;</NoWarn>
   </PropertyGroup>
 
   <PropertyGroup>
     <VersionPrefix>0.0.1</VersionPrefix>
     <VersionSuffix>preview.1</VersionSuffix>
+    <PackageDescription>.NET Analyzers for the Durable Task Framework.</PackageDescription>
     <NeutralLanguage>en</NeutralLanguage>
+    <IncludeBuildOutput>false</IncludeBuildOutput> <!-- Do not include the analyzer as a lib dependency -->
+    <SuppressDependenciesWhenPacking>true</SuppressDependenciesWhenPacking>
+    <IsPackable>false</IsPackable> <!-- Do not publish it until it is ready to release -->
   </PropertyGroup>
 
   <ItemGroup>

test/Analyzers.Tests/Orchestration/DateTimeOrchestrationAnalyzerTests.cs

@@ -369,7 +369,9 @@ static DateTime MyRunAsync(TaskOrchestrationContext context)
 
         await VerifyCS.VerifyDurableTaskCodeFixAsync(code, expected, fix, test =>
         {
-            // TODO: CodeFixBehaviors.SkipLocalDiagnosticCheck is failing this test. This is apparently a bad analyzer practice.
+            // By default, the analyzer will fail the test if the analyzer is 'non-local'. We set this behavior to skip
+            // that check to allow this analyzer to pass, but we should follow up on this as it is a bad practice.
+            // TODO: Investigate and address non-local analyzer behavior.
             test.CodeFixTestBehaviors |= CodeFixTestBehaviors.SkipLocalDiagnosticCheck;
         });
     }