Skip to content

Commit 498cc73

Browse files
committed
udpate by comment
1 parent 390fc5d commit 498cc73

File tree

3 files changed

+11
-13
lines changed

3 files changed

+11
-13
lines changed

src/Abstractions/TaskOrchestrationContext.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ public abstract class TaskOrchestrationContext
6868
/// <summary>
6969
/// Gets the configuration settings for the orchestration context.
7070
/// </summary>
71-
public abstract IDictionary<string, object?> Properties { get; }
71+
public virtual IDictionary<string, object?> Properties { get; } = new Dictionary<string, object?>();
7272

7373
/// <summary>
7474
/// Gets the entity feature, for interacting with entities.

src/Worker/Core/Shims/TaskOrchestrationContextWrapper.cs

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ sealed partial class TaskOrchestrationContextWrapper : TaskOrchestrationContext
2323
readonly OrchestrationInvocationContext invocationContext;
2424
readonly ILogger logger;
2525
readonly object? deserializedInput;
26-
readonly Dictionary<string, object?> properties = new Dictionary<string, object?>();
2726

2827
int newGuidCounter;
2928
object? customStatus;
@@ -39,11 +38,8 @@ public TaskOrchestrationContextWrapper(
3938
OrchestrationContext innerContext,
4039
OrchestrationInvocationContext invocationContext,
4140
object? deserializedInput)
41+
: this(innerContext, invocationContext, deserializedInput, new Dictionary<string, object?>())
4242
{
43-
this.innerContext = Check.NotNull(innerContext);
44-
this.invocationContext = Check.NotNull(invocationContext);
45-
this.logger = this.CreateReplaySafeLogger("Microsoft.DurableTask");
46-
this.deserializedInput = deserializedInput;
4743
}
4844

4945
/// <summary>
@@ -57,11 +53,16 @@ public TaskOrchestrationContextWrapper(
5753
OrchestrationContext innerContext,
5854
OrchestrationInvocationContext invocationContext,
5955
object? deserializedInput,
60-
Dictionary<string, object?> properties)
56+
IEnumerable<KeyValuePair<string, object?>> properties)
6157
{
6258
this.innerContext = Check.NotNull(innerContext);
6359
this.invocationContext = Check.NotNull(invocationContext);
64-
this.properties = Check.NotNull(properties);
60+
if (properties is null)
61+
{
62+
throw new ArgumentNullException(nameof(properties));
63+
}
64+
65+
this.Properties = properties.ToDictionary(pair => pair.Key, pair => pair.Value);
6566
this.logger = this.CreateReplaySafeLogger("Microsoft.DurableTask");
6667
this.deserializedInput = deserializedInput;
6768
}
@@ -84,7 +85,7 @@ public TaskOrchestrationContextWrapper(
8485
/// <summary>
8586
/// Gets the configuration settings for the orchestration.
8687
/// </summary>
87-
public override IDictionary<string, object?> Properties => this.properties;
88+
public override IDictionary<string, object?> Properties { get; } = new Dictionary<string, object?>();
8889

8990
/// <inheritdoc/>
9091
public override TaskOrchestrationEntityFeature Entities

src/Worker/Core/Shims/TaskOrchestrationShim.cs

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,11 +31,8 @@ partial class TaskOrchestrationShim : TaskOrchestration
3131
public TaskOrchestrationShim(
3232
OrchestrationInvocationContext invocationContext,
3333
ITaskOrchestrator implementation)
34+
: this(invocationContext, implementation, new Dictionary<string, object?>())
3435
{
35-
this.invocationContext = Check.NotNull(invocationContext);
36-
this.implementation = Check.NotNull(implementation);
37-
38-
this.logger = Logs.CreateWorkerLogger(this.invocationContext.LoggerFactory, "Orchestrations");
3936
}
4037

4138
/// <summary>

0 commit comments

Comments
 (0)