Skip to content

Commit 5676d0c

Browse files
cgillumcgillum
authored
Add support for history streaming (#370)
Also: replaced submodule with protobuf download script
1 parent e9b42f9 commit 5676d0c

File tree

12 files changed

+859
-51
lines changed

12 files changed

+859
-51
lines changed

‎.gitmodules‎

Lines changed: 0 additions & 3 deletions
This file was deleted.

‎CHANGELOG.md‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,12 @@
99
### Microsoft.DurableTask.Worker
1010

1111
- Add new `IDurableTaskWorkerBuilder AddDurableTaskWorker(IServiceCollection, string?)` API
12+
- Add support for work item history streaming
13+
14+
### Microsoft.DurableTask.Grpc
15+
16+
- Replace submodule for proto files with download script for easier maintenance
17+
- Update to latest proto files
1218

1319
## v1.5.0
1420

‎README.md‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -167,9 +167,7 @@ There are also several features that aren't yet available:
167167

168168
## Obtaining the Protobuf definitions
169169

170-
This project utilizes git submodules to obtain Protobuf definitions from [durabletask-protobuf](https://github.com/microsoft/durabletask-protobuf). You will need to obtain these to build the project.
171-
172-
To get the definitions, run `git submodule update --init --recursive`
170+
This project utilizes protobuf definitions from [durabletask-protobuf](https://github.com/microsoft/durabletask-protobuf), which are copied (vendored) into this repository under the `src/Grpc` directory. See the corresponding [README.md](./src/Grpc/README.md) for more information about how to update the protobuf definitions.
173171

174172
## Contributing
175173

‎azure-pipelines-release.yml‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ variables:
2828

2929
steps:
3030
- checkout: self
31-
submodules: true
3231

3332
- task: UseDotNet@2
3433
displayName: 'Install .NET 6 SDK (ESRP)' # This is needed for ESRP.

‎eng/proto‎

Lines changed: 0 additions & 1 deletion
This file was deleted.

‎eng/templates/build.yml‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ jobs:
2424

2525
steps:
2626
- checkout: self
27-
submodules: true
2827

2928
- task: UseDotNet@2
3029
displayName: 'Install .NET 6 SDK (ESRP)' # This is needed for ESRP.

‎src/Grpc/Grpc.csproj‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<Project Sdk="Microsoft.NET.Sdk">
1+
<Project Sdk="Microsoft.NET.Sdk">
22

33
<PropertyGroup>
44
<TargetFrameworks>netstandard2.0;net6.0</TargetFrameworks>
@@ -18,7 +18,7 @@
1818
</ItemGroup>
1919

2020
<ItemGroup>
21-
<Protobuf Include="$(EngRoot)proto/protos/orchestrator_service.proto" GrpcServices="both" Link="proto/orchestrator_service.proto" />
21+
<Protobuf Include="**/*.proto" GrpcServices="Both" Access="Public" />
2222
</ItemGroup>
2323

2424
</Project>

‎src/Grpc/README.md‎

2.38 KB

gRPC protobuf .NET services for Microsoft.DurableTask.

Commonly used types:

  • TaskHubSidecarService
  • TaskHubSidecarServiceClient

For more information, see https://github.com/microsoft/durabletask-dotnet

Durable Task Protobuf

This directory contains the protobuf definitions for the Durable Task SDK, which are used to generate the C# source code for the gRPC service contracts. The official protobuf definitions are maintained in the Durable Task Protobuf repository.

Updating the Protobuf Definitions

To update the protobuf definitions in this directory, follow these steps:

  1. Make sure you have PowerShell installed on your machine.
  2. Run the following command to download the latest protobuf definitions from the Durable Task SDK repository:
.\refresh-protos.ps1

This script will download the latest protobuf definitions from the https://github.com/microsoft/durabletask-protobuf repository and copy them to this directory.

By default, the latest versions of the protobufs are downloaded from the main branch. To specify an alternative branch, use the -branch parameter:

.\refresh-protos.ps1 -branch <branch-name>

The versions.txt file in this directory contains the list of protobuf files and their commit hashes that were last downloaded. It is updated automatically by the refresh-protos.ps1 script.

0 commit comments

Comments
 (0)