initial add async versions ser/deser

Author: YunchuWang

src/Abstractions/DataConverter.cs

@@ -49,4 +49,46 @@ public abstract class DataConverter
     /// </returns>
     [return: NotNullIfNotNull("data")]
     public virtual T? Deserialize<T>(string? data) => (T?)(this.Deserialize(data, typeof(T)) ?? default);
+
+    /// <summary>
+    /// Asynchronously serializes <paramref name="value"/> into a text string.
+    /// Default implementation delegates to <see cref="Serialize(object?)"/>.
+    /// </summary>
+    /// <param name="value">The value to be serialized.</param>
+    /// <param name="cancellationToken">Cancellation token.</param>
+    /// <returns>A task whose result is the serialized string or <c>null</c>.</returns>
+    public virtual ValueTask<string?> SerializeAsync(object? value, CancellationToken cancellationToken = default)
+    {
+        return new ValueTask<string?>(this.Serialize(value));
+    }
+
+    /// <summary>
+    /// Asynchronously deserializes <paramref name="data"/> into an object of type <paramref name="targetType"/>.
+    /// Default implementation delegates to <see cref="Deserialize(string?, Type)"/>.
+    /// </summary>
+    /// <param name="data">The text data to be deserialized.</param>
+    /// <param name="targetType">The type to deserialize to.</param>
+    /// <param name="cancellationToken">Cancellation token.</param>
+    /// <returns>A task whose result is the deserialized value or <c>null</c>.</returns>
+    public virtual ValueTask<object?> DeserializeAsync(
+        string? data,
+        Type targetType,
+        CancellationToken cancellationToken = default)
+    {
+        return new ValueTask<object?>(this.Deserialize(data, targetType));
+    }
+
+    /// <summary>
+    /// Asynchronously deserializes <paramref name="data"/> into an object of type <typeparamref name="T"/>.
+    /// </summary>
+    /// <typeparam name="T">The type to deserialize to.</typeparam>
+    /// <param name="data">The text data to be deserialized.</param>
+    /// <param name="cancellationToken">Cancellation token.</param>
+    /// <returns>A task whose result is the deserialized value or <c>null</c>.</returns>
+    public virtual ValueTask<T?> DeserializeAsync<T>(
+        string? data,
+        CancellationToken cancellationToken = default)
+    {
+        return new ValueTask<T?>(this.Deserialize<T>(data));
+    }
 }

src/Extensions/AzureBlobPayloads/Converters/LargePayloadDataConverter.cs

@@ -1,6 +1,7 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
 
+using System.Diagnostics.CodeAnalysis;
 using System.Text;
 
 namespace Microsoft.DurableTask.Converters;
@@ -20,25 +21,39 @@ namespace Microsoft.DurableTask.Converters;
 public sealed class LargePayloadDataConverter(
     DataConverter innerConverter,
     IPayloadStore payloadStore,
-    LargePayloadStorageOptions largePayloadStorageOptions
-) : DataConverter
+    LargePayloadStorageOptions largePayloadStorageOptions) : DataConverter
 {
-
     readonly DataConverter innerConverter = innerConverter ?? throw new ArgumentNullException(nameof(innerConverter));
     readonly IPayloadStore payLoadStore = payloadStore ?? throw new ArgumentNullException(nameof(payloadStore));
     readonly LargePayloadStorageOptions largePayloadStorageOptions = largePayloadStorageOptions ?? throw new ArgumentNullException(nameof(largePayloadStorageOptions));
+
     // Use UTF-8 without a BOM (encoderShouldEmitUTF8Identifier=false). JSON in UTF-8 should not include a
     // byte order mark per RFC 8259, and omitting it avoids hidden extra bytes that could skew the
     // externalization threshold calculation and prevents interop issues with strict JSON parsers.
     // A few legacy tools rely on a BOM for encoding detection, but modern JSON tooling assumes BOM-less UTF-8.
     readonly Encoding utf8 = new UTF8Encoding(false);
 
+    /// <inheritdoc/>
+    [return: NotNullIfNotNull("value")]
+    public override string? Serialize(object? value)
+    {
+        throw new NotImplementedException();
+    }
+
+    /// <inheritdoc/>
+    [return: NotNullIfNotNull("data")]
+    public override object? Deserialize(string? data, Type targetType)
+    {
+        throw new NotImplementedException();
+    }
+
     /// <summary>
     /// Serializes the value to a JSON string and uploads it to the external payload store if it exceeds the configured threshold.
     /// </summary>
     /// <param name="value">The value to serialize.</param>
+    /// <param name="cancellationToken">Cancellation token.</param>
     /// <returns>The serialized value or the token if externalized.</returns>
-    public override string? Serialize(object? value)
+    public override async ValueTask<string?> SerializeAsync(object? value, CancellationToken cancellationToken = default)
     {
         string? json = this.innerConverter.Serialize(value);
 
@@ -55,17 +70,20 @@ LargePayloadStorageOptions largePayloadStorageOptions
 
         // Upload synchronously in this context by blocking on async. SDK call sites already run on threadpool.
         byte[] bytes = this.utf8.GetBytes(json);
-        string token = this.payLoadStore.UploadAsync(bytes, CancellationToken.None).GetAwaiter().GetResult();
-        return token;
+        return await this.payLoadStore.UploadAsync(bytes, cancellationToken);
     }
 
     /// <summary>
     /// Deserializes the JSON string or resolves the token to the original value.
     /// </summary>
     /// <param name="data">The JSON string or token.</param>
     /// <param name="targetType">The type to deserialize to.</param>
+    /// <param name="cancellationToken">Cancellation token.</param>
     /// <returns>The deserialized value.</returns>
-    public override object? Deserialize(string? data, Type targetType)
+    public override async ValueTask<object?> DeserializeAsync(
+        string? data,
+        Type targetType,
+        CancellationToken cancellationToken = default)
     {
         if (data is null)
         {
@@ -75,7 +93,7 @@ LargePayloadStorageOptions largePayloadStorageOptions
         string toDeserialize = data;
         if (this.payLoadStore.IsKnownPayloadToken(data))
         {
-            toDeserialize = this.payLoadStore.DownloadAsync(data, CancellationToken.None).GetAwaiter().GetResult();
+            toDeserialize = await this.payLoadStore.DownloadAsync(data, CancellationToken.None);
         }
 
         return this.innerConverter.Deserialize(StripArrayCharacters(toDeserialize), targetType);
@@ -92,5 +110,3 @@ LargePayloadStorageOptions largePayloadStorageOptions
         return input;
     }
 }
-
-