Skip to content

Commit 7a7cf8a

Browse files
CopilotYunchuWang
andcommitted
Address PR feedback: fix parameter shadowing, remove unused code
Co-authored-by: YunchuWang <[email protected]>
1 parent 6022cd9 commit 7a7cf8a

File tree

1 file changed

+1
-33
lines changed

1 file changed

+1
-33
lines changed

test/Worker/Grpc.Tests/LoggingCategoryTests.cs

Lines changed: 1 addition & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ namespace Microsoft.DurableTask.Worker.Grpc.Tests;
2020
public class LoggingCategoryTests
2121
{
2222
const string NewGrpcCategory = "Microsoft.DurableTask.Worker.Grpc";
23-
const string LegacyCategory = "Microsoft.DurableTask";
2423

2524
[Fact]
2625
public void Worker_UsesLegacyCategories_ByDefault()
@@ -164,37 +163,6 @@ public void DualCategoryLogger_BeginScope_CreatesScopeInBothLoggers()
164163
scope.Should().NotBeNull();
165164
}
166165

167-
[Fact]
168-
public void LoggingOptions_UseLegacyCategories_DefaultsToTrue()
169-
{
170-
// Arrange & Act
171-
var options = new DurableTaskWorkerOptions();
172-
173-
// Assert
174-
options.Logging.UseLegacyCategories.Should().BeTrue("backward compatibility is enabled by default");
175-
}
176-
}
177-
178-
sealed class OptionsMonitorStub<T> : IOptionsMonitor<T>
179-
{
180-
readonly T value;
181-
182-
public OptionsMonitorStub(T value)
183-
{
184-
this.value = value;
185-
}
186-
187-
public T CurrentValue => this.value;
188-
189-
public T Get(string? name) => this.value;
190-
191-
public IDisposable OnChange(Action<T, string?> listener) => NullDisposable.Instance;
192-
193-
sealed class NullDisposable : IDisposable
194-
{
195-
public static readonly NullDisposable Instance = new();
196-
public void Dispose() { }
197-
}
198166
}
199167

200168
sealed class NullOutput : ITestOutputHelper
@@ -212,7 +180,7 @@ public SimpleLoggerFactory(ILoggerProvider provider)
212180
this.provider = provider;
213181
}
214182

215-
public void AddProvider(ILoggerProvider provider)
183+
public void AddProvider(ILoggerProvider loggerProvider)
216184
{
217185
// No-op; single provider
218186
}

0 commit comments

Comments
 (0)