Skip to content

Commit 94b3850

Browse files
authored
Add Code Review Guidelines to copilot-instructions.md (#522)
1 parent 97f8187 commit 94b3850

File tree

1 file changed

+9
-1
lines changed

1 file changed

+9
-1
lines changed

.github/copilot-instructions.md

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,4 +65,12 @@ Unit tests should follow these guidelines:
6565
- Use the Moq library for mocking objects where possible.
6666
- Validate that each test actually tests the target behavior, e.g. we should not have tests that create a mock, call the mock and then verify that the mock was called, without the target code being involved. We also shouldn't have tests that test language features, e.g. something that the compiler would catch anyway.
6767
- Avoid adding excessive comments to tests. Instead favor clear easy to understand code.
68-
- Follow the patterns in the unit tests in the same project or classes to which new tests are being added.
68+
- Follow the patterns in the unit tests in the same project or classes to which new tests are being added.
69+
70+
## Code Review Guidelines
71+
72+
When reviewing code, follow these guidelines:
73+
74+
- Provide all review comments in a single review pass. Avoid scattering feedback across multiple partial reviews; consolidate findings into one coherent review round.
75+
- Do not generate false-positive or already-resolved comments when new commits are pushed. Only surface issues that still apply after the latest changes, and avoid re-posting comments that have been addressed or are no longer relevant.
76+
- Do not re-post a review comment if a user has directly responded to it with justification for why the code exists as written. Respect user explanations and avoid redundant feedback on justified code decisions.

0 commit comments

Comments
 (0)