some fb

Author: YunchuWang

src/Abstractions/Converters/BlobPayloadStore.cs

@@ -37,7 +37,7 @@ public BlobPayloadStore(LargePayloadStorageOptions options)
     }
 
     /// <inheritdoc/>
-    public async Task<string> UploadAsync(string contentType, ReadOnlyMemory<byte> payloadBytes, CancellationToken cancellationToken)
+    public async Task<string> UploadAsync(ReadOnlyMemory<byte> payloadBytes, CancellationToken cancellationToken)
     {
         // Ensure container exists
         await this.containerClient.CreateIfNotExistsAsync(PublicAccessType.None, cancellationToken: cancellationToken).ConfigureAwait(false);

src/Abstractions/Converters/IPayloadStore.cs

@@ -11,11 +11,10 @@ public interface IPayloadStore
     /// <summary>
     /// Uploads a payload and returns an opaque reference token that can be embedded in orchestration messages.
     /// </summary>
-    /// <param name="contentType">The content type of the payload (e.g., application/json).</param>
     /// <param name="payloadBytes">The payload bytes.</param>
     /// <param name="cancellationToken">Cancellation token.</param>
     /// <returns>Opaque reference token.</returns>
-    Task<string> UploadAsync(string contentType, ReadOnlyMemory<byte> payloadBytes, CancellationToken cancellationToken);
+    Task<string> UploadAsync(ReadOnlyMemory<byte> payloadBytes, CancellationToken cancellationToken);
 
     /// <summary>
     /// Downloads the payload referenced by the token.

src/Abstractions/Converters/LargePayloadDataConverter.cs

@@ -55,7 +55,7 @@ public sealed class LargePayloadDataConverter(DataConverter innerConverter, IPay
 
         // Upload synchronously in this context by blocking on async. SDK call sites already run on threadpool.
         byte[] bytes = this.utf8.GetBytes(json);
-        string token = this.payLoadStore.UploadAsync("application/json", bytes, CancellationToken.None).GetAwaiter().GetResult();
+        string token = this.payLoadStore.UploadAsync(bytes, CancellationToken.None).GetAwaiter().GetResult();
         return token;
     }
 

src/Abstractions/DataConverter.cs

@@ -10,9 +10,11 @@ namespace Microsoft.DurableTask;
 /// </summary>
 /// <remarks>
 /// Implementations of this abstract class are free to use any serialization method. The default implementation
-/// uses the JSON serializer from the System.Text.Json namespace. Implementations may optionally externalize
-/// large payloads and return an opaque reference string that can be resolved during deserialization.
-/// These methods all accept null values, in which case the return value should also be null.
+/// uses the JSON serializer from the System.Text.Json namespace. Currently only strings are supported as
+/// the serialized representation of data. Byte array payloads and streams are not supported by this abstraction.
+/// Note that these methods all accept null values, in which case the return value should also be null.
+/// Implementations may choose to return a pointer or reference (such as an external token) to the data
+/// instead of the actual serialized data itself.
 /// </remarks>
 public abstract class DataConverter
 {

test/Grpc.IntegrationTests/LargePayloadTests.cs

@@ -380,7 +380,7 @@ public InMemoryPayloadStore(Dictionary<string, string> shared)
         int downloadCount;
         public int DownloadCount => this.downloadCount;
 
-        public Task<string> UploadAsync(string contentType, ReadOnlyMemory<byte> payloadBytes, CancellationToken cancellationToken)
+        public Task<string> UploadAsync(ReadOnlyMemory<byte> payloadBytes, CancellationToken cancellationToken)
         {
             Interlocked.Increment(ref this.uploadCount);
             string json = System.Text.Encoding.UTF8.GetString(payloadBytes.Span);