Skip to content

Commit a27a0f0

Browse files
committed
Add Obsolete attribute to orchestration filter
This commit adds an Obsolete attribute to the new orchestration filtering. This is being done because we want to provide the functionality but also leave the implementation more open. This marks the API as Obsolete("Experimental") to show that. Signed-off-by: Hal Spang <[email protected]>
1 parent 954b4a7 commit a27a0f0

File tree

2 files changed

+5
-0
lines changed

2 files changed

+5
-0
lines changed

src/Worker/Core/DependencyInjection/DurableTaskWorkerBuilderExtensions.cs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -116,6 +116,8 @@ public static IDurableTaskWorkerBuilder UseVersioning(this IDurableTaskWorkerBui
116116
/// <param name="builder">The builder to set the builder target for.</param>
117117
/// <typeparam name="TOrchestrationFilter">The implementation of a <see cref="IOrchestrationFilter"/> that will be bound.</typeparam>
118118
/// <returns>The same <see cref="IDurableTaskWorkerBuilder"/> instance, allowing for method chaining.</returns>
119+
120+
[Obsolete("Experimental")]
119121
public static IDurableTaskWorkerBuilder UseOrchestrationFilter<TOrchestrationFilter>(this IDurableTaskWorkerBuilder builder) where TOrchestrationFilter : class, IOrchestrationFilter
120122
{
121123
Check.NotNull(builder);
@@ -129,6 +131,7 @@ public static IDurableTaskWorkerBuilder UseOrchestrationFilter<TOrchestrationFil
129131
/// <param name="builder">The builder to set the builder target for.</param>
130132
/// <param name="filter">The instance of an <see cref="IOrchestrationFilter"/> to use.</param>
131133
/// <returns>The same <see cref="IDurableTaskWorkerBuilder"/> instance, allowing for method chaining.</returns>
134+
[Obsolete("Experimental")]
132135
public static IDurableTaskWorkerBuilder UseOrchestrationFilter(this IDurableTaskWorkerBuilder builder, IOrchestrationFilter filter)
133136
{
134137
Check.NotNull(builder);

test/Grpc.IntegrationTests/OrchestrationPatterns.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -979,6 +979,7 @@ public async Task RunActivityWithTags()
979979
Assert.Equal("Hello from tagged activity, World!", metadata.ReadOutputAs<string>());
980980
}
981981

982+
[Obsolete("Experimental")]
982983
[Fact]
983984
public async Task FilterOrchestrationsByName()
984985
{
@@ -1008,6 +1009,7 @@ public async Task FilterOrchestrationsByName()
10081009
await Assert.ThrowsAsync<OperationCanceledException>(async () => await server.Client.WaitForInstanceCompletionAsync(instanceId, new CancellationTokenSource(TimeSpan.FromSeconds(5)).Token));
10091010
}
10101011

1012+
[Obsolete("Experimental")]
10111013
[Fact]
10121014
public async Task FilterOrchestrationsByTag()
10131015
{

0 commit comments

Comments
 (0)