abstract payloadstore

Author: YunchuWang

src/Extensions/AzureBlobPayloads/PayloadStore/BlobPayloadStore.cs

@@ -62,7 +62,7 @@ public BlobPayloadStore(LargePayloadStorageOptions options)
     }
 
     /// <inheritdoc/>
-    public async Task<string> UploadAsync(ReadOnlyMemory<byte> payloadBytes, CancellationToken cancellationToken)
+    public override async Task<string> UploadAsync(ReadOnlyMemory<byte> payloadBytes, CancellationToken cancellationToken)
     {
         // One blob per payload using GUID-based name for uniqueness (stable across retries)
         string timestamp = DateTimeOffset.UtcNow.ToString("yyyy/MM/dd/HH/mm/ss", CultureInfo.InvariantCulture);
@@ -107,7 +107,7 @@ public async Task<string> UploadAsync(ReadOnlyMemory<byte> payloadBytes, Cancell
     }
 
     /// <inheritdoc/>
-    public async Task<string> DownloadAsync(string token, CancellationToken cancellationToken)
+    public override async Task<string> DownloadAsync(string token, CancellationToken cancellationToken)
     {
         (string container, string name) = DecodeToken(token);
         if (!string.Equals(container, this.containerClient.Name, StringComparison.Ordinal))
@@ -139,7 +139,7 @@ public async Task<string> DownloadAsync(string token, CancellationToken cancella
     }
 
     /// <inheritdoc/>
-    public bool IsKnownPayloadToken(string value)
+    public override bool IsKnownPayloadToken(string value)
     {
         if (string.IsNullOrEmpty(value))
         {

src/Extensions/AzureBlobPayloads/PayloadStore/IPayloadStore.cs

@@ -6,29 +6,29 @@ namespace Microsoft.DurableTask;
 /// <summary>
 /// Abstraction for storing and retrieving large payloads out-of-band.
 /// </summary>
-public interface IPayloadStore
+public abstract class IPayloadStore
 {
     /// <summary>
     /// Uploads a payload and returns an opaque reference token that can be embedded in orchestration messages.
     /// </summary>
     /// <param name="payloadBytes">The payload bytes.</param>
     /// <param name="cancellationToken">Cancellation token.</param>
     /// <returns>Opaque reference token.</returns>
-    Task<string> UploadAsync(ReadOnlyMemory<byte> payloadBytes, CancellationToken cancellationToken);
+    public abstract Task<string> UploadAsync(ReadOnlyMemory<byte> payloadBytes, CancellationToken cancellationToken);
 
     /// <summary>
     /// Downloads the payload referenced by the token.
     /// </summary>
     /// <param name="token">The opaque reference token.</param>
     /// <param name="cancellationToken">Cancellation token.</param>
     /// <returns>Payload string.</returns>
-    Task<string> DownloadAsync(string token, CancellationToken cancellationToken);
+    public abstract Task<string> DownloadAsync(string token, CancellationToken cancellationToken);
 
     /// <summary>
     /// Returns true if the specified value appears to be a token understood by this store.
     /// Implementations should not throw for unknown tokens.
     /// </summary>
     /// <param name="value">The value to check.</param>
     /// <returns><c>true</c> if the value is a token issued by this store; otherwise, <c>false</c>.</returns>
-    bool IsKnownPayloadToken(string value);
+    public abstract bool IsKnownPayloadToken(string value);
 }

test/Grpc.IntegrationTests/LargePayloadTests.cs

@@ -623,7 +623,7 @@ public InMemoryPayloadStore(Dictionary<string, string> shared)
         int downloadCount;
         public int DownloadCount => this.downloadCount;
 
-        public Task<string> UploadAsync(ReadOnlyMemory<byte> payloadBytes, CancellationToken cancellationToken)
+        public override Task<string> UploadAsync(ReadOnlyMemory<byte> payloadBytes, CancellationToken cancellationToken)
         {
             Interlocked.Increment(ref this.uploadCount);
             string json = System.Text.Encoding.UTF8.GetString(payloadBytes.Span);
@@ -633,13 +633,13 @@ public Task<string> UploadAsync(ReadOnlyMemory<byte> payloadBytes, CancellationT
             return Task.FromResult(token);
         }
 
-        public Task<string> DownloadAsync(string token, CancellationToken cancellationToken)
+        public override Task<string> DownloadAsync(string token, CancellationToken cancellationToken)
         {
             Interlocked.Increment(ref this.downloadCount);
             return Task.FromResult(this.tokenToPayload[token]);
         }
 
-        public bool IsKnownPayloadToken(string value)
+        public override bool IsKnownPayloadToken(string value)
         {
             return value.StartsWith(TokenPrefix, StringComparison.Ordinal);
         }