more

Author: YunchuWang

src/Client/Grpc/GrpcDurableEntityClient.cs

@@ -95,15 +95,15 @@ public override async Task SignalEntityAsync(
     /// <inheritdoc/>
     public override Task<EntityMetadata<TState>?> GetEntityAsync<TState>(
         EntityInstanceId id, bool includeState = false, CancellationToken cancellation = default)
-        => this.GetEntityCoreAsync(id, includeState, this.ToEntityMetadata<TState>, cancellation);
+        => this.GetEntityCoreAsync(id, includeState, (e, s) => this.ToEntityMetadata<TState>(e, s), cancellation);
 
     /// <inheritdoc/>
     public override AsyncPageable<EntityMetadata> GetAllEntitiesAsync(EntityQuery? filter = null)
         => this.GetAllEntitiesCoreAsync(filter, (x, s) => this.ToEntityMetadata(x, s));
 
     /// <inheritdoc/>
     public override AsyncPageable<EntityMetadata<TState>> GetAllEntitiesAsync<TState>(EntityQuery? filter = null)
-        => this.GetAllEntitiesCoreAsync(filter, this.ToEntityMetadata<TState>);
+        => this.GetAllEntitiesCoreAsync(filter, (x, s) => this.ToEntityMetadata<TState>(x, s));
 
     /// <inheritdoc/>
     public override async Task<CleanEntityStorageResult> CleanEntityStorageAsync(

src/Client/OrchestrationServiceClientShim/ShimDurableEntityClient.cs

@@ -26,11 +26,6 @@ class ShimDurableEntityClient(string name, ShimDurableTaskClientOptions options)
 
     DataConverter Converter => this.options.DataConverter;
 
-    /// <summary>
-    /// Gets a value indicating whether the DataConverter supports async operations (LargePayload enabled).
-    /// </summary>
-    bool SupportsAsyncSerialization => this.options.EnableLargePayloadSupport;
-
     /// <inheritdoc/>
     public override async Task<CleanEntityStorageResult> CleanEntityStorageAsync(
         CleanEntityStorageRequest? request = null,
@@ -61,9 +56,7 @@ public override AsyncPageable<EntityMetadata> GetAllEntitiesAsync(EntityQuery? f
 
     /// <inheritdoc/>
     public override AsyncPageable<EntityMetadata<T>> GetAllEntitiesAsync<T>(EntityQuery? filter = null)
-        => this.SupportsAsyncSerialization
-            ? this.GetAllEntitiesAsync(this.Convert<T>, filter)
-            : this.GetAllEntitiesAsync(this.ConvertSync<T>, filter);
+        => this.GetAllEntitiesAsync(this.Convert<T>, filter);
 
     /// <inheritdoc/>
     public override async Task<EntityMetadata?> GetEntityAsync(
@@ -89,7 +82,7 @@ public override async Task SignalEntityAsync(
         Check.NotNull(id.Key);
 
         DateTimeOffset? scheduledTime = options?.SignalTime;
-        string? serializedInput = this.SupportsAsyncSerialization
+        string? serializedInput = this.options.EnableLargePayloadSupport
             ? await this.Converter.SerializeAsync(input, cancellation)
             : this.Converter.Serialize(input);
 
@@ -176,7 +169,7 @@ AsyncPageable<TMetadata> GetAllEntitiesAsync<TMetadata>(
 
     async Task<EntityMetadata<T>> Convert<T>(EntityBackendQueries.EntityMetadata metadata)
     {
-        T? state = this.SupportsAsyncSerialization
+        T? state = this.options.EnableLargePayloadSupport
             ? await this.Converter.DeserializeAsync<T>(metadata.SerializedState)
             : this.Converter.Deserialize<T>(metadata.SerializedState);
 
@@ -190,20 +183,6 @@ async Task<EntityMetadata<T>> Convert<T>(EntityBackendQueries.EntityMetadata met
             };
     }
 
-    EntityMetadata<T> ConvertSync<T>(EntityBackendQueries.EntityMetadata metadata)
-    {
-        T? state = this.Converter.Deserialize<T>(metadata.SerializedState);
-
-        return new(
-            metadata.EntityId.ConvertFromCore(),
-            state)
-            {
-                LastModifiedTime = metadata.LastModifiedTime,
-                BacklogQueueSize = metadata.BacklogQueueSize,
-                LockedBy = metadata.LockedBy,
-            };
-    }
-
     async Task<EntityMetadata<T>?> Convert<T>(EntityBackendQueries.EntityMetadata? metadata)
     {
         if (metadata is null)
@@ -220,7 +199,7 @@ EntityMetadata Convert(EntityBackendQueries.EntityMetadata metadata)
             ? null
             : new SerializedData(metadata.SerializedState, this.Converter)
             {
-                EnableLargePayloadSupport = this.SupportsAsyncSerialization,
+                EnableLargePayloadSupport = this.options.EnableLargePayloadSupport,
             };
         return new(new EntityInstanceId(metadata.EntityId.Name, metadata.EntityId.Key), data)
         {