Skip to content

Commit b4527cc

Browse files
YunchuWangYunchuWang
committed
enabled always
1 parent 6387ad2 commit b4527cc

File tree

4 files changed

+2
-25
lines changed

4 files changed

+2
-25
lines changed

‎samples/LargePayloadConsoleApp/Program.cs‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@
2626
b.UseDurableTaskScheduler(schedulerConnectionString);
2727
b.UseExternalizedPayloads(opts =>
2828
{
29-
opts.Enabled = true;
3029
// Keep threshold small to force externalization for demo purposes
3130
opts.ExternalizeThresholdBytes = 1024; // 1KB
3231
// Default to local Azurite/emulator. Override via environment or appsettings if desired.
@@ -67,7 +66,6 @@
6766
});
6867
b.UseExternalizedPayloads(opts =>
6968
{
70-
opts.Enabled = true;
7169
opts.ExternalizeThresholdBytes = 1024; // mirror client
7270
opts.ConnectionString = Environment.GetEnvironmentVariable("DURABLETASK_STORAGE") ?? "UseDevelopmentStorage=true";
7371
opts.ContainerName = Environment.GetEnvironmentVariable("DURABLETASK_PAYLOAD_CONTAINER") ?? "durabletask-payloads";

‎src/Abstractions/Converters/LargePayloadDataConverter.cs‎

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ public sealed class LargePayloadDataConverter(DataConverter innerConverter, IPay
2727
readonly Encoding utf8 = new UTF8Encoding(false);
2828

2929
/// <inheritdoc/>
30-
public override bool UsesExternalStorage => this.largePayloadStorageOptions.Enabled || this.innerConverter.UsesExternalStorage;
30+
public override bool UsesExternalStorage => true;
3131

3232
/// <summary>
3333
/// Serializes the value to a JSON string and uploads it to the external payload store if it exceeds the configured threshold.
@@ -42,10 +42,6 @@ public sealed class LargePayloadDataConverter(DataConverter innerConverter, IPay
4242
}
4343

4444
string json = this.innerConverter.Serialize(value) ?? "null";
45-
if (!this.largePayloadStorageOptions.Enabled)
46-
{
47-
return json;
48-
}
4945

5046
int byteCount = this.utf8.GetByteCount(json);
5147
if (byteCount < this.largePayloadStorageOptions.ExternalizeThresholdBytes)
@@ -73,7 +69,7 @@ public sealed class LargePayloadDataConverter(DataConverter innerConverter, IPay
7369
}
7470

7571
string toDeserialize = data;
76-
if (this.largePayloadStorageOptions.Enabled && data.StartsWith(TokenPrefix, StringComparison.Ordinal))
72+
if (data.StartsWith(TokenPrefix, StringComparison.Ordinal))
7773
{
7874
toDeserialize = this.payLoadStore.DownloadAsync(data, CancellationToken.None).GetAwaiter().GetResult();
7975
}

‎src/Abstractions/Converters/LargePayloadStorageOptions.cs‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -27,11 +27,6 @@ public LargePayloadStorageOptions(string connectionString)
2727
this.ConnectionString = connectionString;
2828
}
2929

30-
/// <summary>
31-
/// Gets or sets a value indicating whether externalized payload storage is enabled.
32-
/// </summary>
33-
public bool Enabled { get; set; } = true;
34-
3530
/// <summary>
3631
/// Gets or sets the threshold in bytes at which payloads are externalized. Default is 900_000 bytes.
3732
/// </summary>

‎test/Grpc.IntegrationTests/LargePayloadTests.cs‎

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@ public async Task OrchestrationInput_IsExternalizedByClient_ResolvedByWorker()
3232
// Enable externalization on the worker
3333
worker.UseExternalizedPayloads(opts =>
3434
{
35-
opts.Enabled = true;
3635
opts.ExternalizeThresholdBytes = 1024; // small threshold to force externalization for test data
3736
opts.ContainerName = "test";
3837
opts.ConnectionString = "UseDevelopmentStorage=true";
@@ -46,7 +45,6 @@ public async Task OrchestrationInput_IsExternalizedByClient_ResolvedByWorker()
4645
// Enable externalization on the client
4746
client.UseExternalizedPayloads(opts =>
4847
{
49-
opts.Enabled = true;
5048
opts.ExternalizeThresholdBytes = 1024;
5149
opts.ContainerName = "test";
5250
opts.ConnectionString = "UseDevelopmentStorage=true";
@@ -93,7 +91,6 @@ public async Task ActivityInput_IsExternalizedByWorker_ResolvedByActivity()
9391

9492
worker.UseExternalizedPayloads(opts =>
9593
{
96-
opts.Enabled = true;
9794
opts.ExternalizeThresholdBytes = 1024; // force externalization for activity input
9895
opts.ContainerName = "test";
9996
opts.ConnectionString = "UseDevelopmentStorage=true";
@@ -135,7 +132,6 @@ public async Task ActivityOutput_IsExternalizedByWorker_ResolvedByOrchestrator()
135132

136133
worker.UseExternalizedPayloads(opts =>
137134
{
138-
opts.Enabled = true;
139135
opts.ExternalizeThresholdBytes = 1024; // force externalization for activity result
140136
opts.ContainerName = "test";
141137
opts.ConnectionString = "UseDevelopmentStorage=true";
@@ -177,7 +173,6 @@ public async Task QueryCompletedInstance_DownloadsExternalizedOutputOnClient()
177173

178174
worker.UseExternalizedPayloads(opts =>
179175
{
180-
opts.Enabled = true;
181176
opts.ExternalizeThresholdBytes = 1024; // force externalization on worker
182177
opts.ContainerName = "test";
183178
opts.ConnectionString = "UseDevelopmentStorage=true";
@@ -188,7 +183,6 @@ public async Task QueryCompletedInstance_DownloadsExternalizedOutputOnClient()
188183
{
189184
client.UseExternalizedPayloads(opts =>
190185
{
191-
opts.Enabled = true;
192186
opts.ExternalizeThresholdBytes = 1024; // allow client to resolve on query
193187
opts.ContainerName = "test";
194188
opts.ConnectionString = "UseDevelopmentStorage=true";
@@ -230,7 +224,6 @@ public async Task BelowThreshold_NotExternalized()
230224

231225
worker.UseExternalizedPayloads(opts =>
232226
{
233-
opts.Enabled = true;
234227
opts.ExternalizeThresholdBytes = 2 * 1024 * 1024; // 2MB, higher than payload
235228
opts.ContainerName = "test";
236229
opts.ConnectionString = "UseDevelopmentStorage=true";
@@ -241,7 +234,6 @@ public async Task BelowThreshold_NotExternalized()
241234
{
242235
client.UseExternalizedPayloads(opts =>
243236
{
244-
opts.Enabled = true;
245237
opts.ExternalizeThresholdBytes = 2 * 1024 * 1024; // 2MB, higher than payload
246238
opts.ContainerName = "test";
247239
opts.ConnectionString = "UseDevelopmentStorage=true";
@@ -281,7 +273,6 @@ public async Task ExternalEventPayload_IsExternalizedByClient_ResolvedByWorker()
281273

282274
worker.UseExternalizedPayloads(opts =>
283275
{
284-
opts.Enabled = true;
285276
opts.ExternalizeThresholdBytes = 1024; // force externalization
286277
opts.ContainerName = "test";
287278
opts.ConnectionString = "UseDevelopmentStorage=true";
@@ -292,7 +283,6 @@ public async Task ExternalEventPayload_IsExternalizedByClient_ResolvedByWorker()
292283
{
293284
client.UseExternalizedPayloads(opts =>
294285
{
295-
opts.Enabled = true;
296286
opts.ExternalizeThresholdBytes = 1024; // force externalization
297287
opts.ContainerName = "test";
298288
opts.ConnectionString = "UseDevelopmentStorage=true";
@@ -338,7 +328,6 @@ public async Task OutputAndCustomStatus_ExternalizedByWorker_ResolvedOnQuery()
338328

339329
worker.UseExternalizedPayloads(opts =>
340330
{
341-
opts.Enabled = true;
342331
opts.ExternalizeThresholdBytes = 1024; // ensure externalization for status/output
343332
opts.ContainerName = "test";
344333
opts.ConnectionString = "UseDevelopmentStorage=true";
@@ -349,7 +338,6 @@ public async Task OutputAndCustomStatus_ExternalizedByWorker_ResolvedOnQuery()
349338
{
350339
client.UseExternalizedPayloads(opts =>
351340
{
352-
opts.Enabled = true;
353341
opts.ExternalizeThresholdBytes = 1024; // ensure resolution on query
354342
opts.ContainerName = "test";
355343
opts.ConnectionString = "UseDevelopmentStorage=true";

0 commit comments

Comments
 (0)