Skip to content

Commit ba5e5ea

Browse files
committed
update by comment and also fix some warnings
1 parent b73cd05 commit ba5e5ea

File tree

5 files changed

+6
-11
lines changed

5 files changed

+6
-11
lines changed

src/Abstractions/TaskOrchestrationContext.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ public abstract class TaskOrchestrationContext
6868
/// <summary>
6969
/// Gets the configuration settings for the orchestration context.
7070
/// </summary>
71-
public virtual IDictionary<string, object?> Properties { get; } = new Dictionary<string, object?>();
71+
public virtual IReadOnlyDictionary<string, object?> Properties { get; } = new Dictionary<string, object?>();
7272

7373
/// <summary>
7474
/// Gets the entity feature, for interacting with entities.

src/ScheduledTasks/Client/ScheduledTaskClient.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ namespace Microsoft.DurableTask.ScheduledTasks;
55

66
/// <summary>
77
/// Client for managing scheduled tasks.
8-
/// Provides methods to retrieve a ScheduleClient, list all schedules,
8+
/// Provides methods to retrieve a ScheduleClient, list all schedules,
99
/// and get details of a specific schedule.
1010
/// </summary>
1111
public abstract class ScheduledTaskClient

src/ScheduledTasks/Models/ScheduleState.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,4 +50,4 @@ public void RefreshScheduleRunExecutionToken()
5050
{
5151
this.ExecutionToken = Guid.NewGuid().ToString("N");
5252
}
53-
}
53+
}

src/Shared/AzureManaged/GrpcRetryPolicyDefaults.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@ sealed class GrpcRetryPolicyDefaults
3939
/// </remarks>
4040
public static readonly ServiceConfig DefaultServiceConfig;
4141

42-
4342
/// <summary>
4443
/// The default retry policy for gRPC operations.
4544
/// </summary>

src/Worker/Core/Shims/TaskOrchestrationContextWrapper.cs

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -53,16 +53,12 @@ public TaskOrchestrationContextWrapper(
5353
OrchestrationContext innerContext,
5454
OrchestrationInvocationContext invocationContext,
5555
object? deserializedInput,
56-
IEnumerable<KeyValuePair<string, object?>> properties)
56+
Dictionary<string, object?> properties)
5757
{
5858
this.innerContext = Check.NotNull(innerContext);
5959
this.invocationContext = Check.NotNull(invocationContext);
60-
if (properties is null)
61-
{
62-
throw new ArgumentNullException(nameof(properties));
63-
}
60+
this.Properties = Check.NotNull(properties);
6461

65-
this.Properties = properties.ToDictionary(pair => pair.Key, pair => pair.Value);
6662
this.logger = this.CreateReplaySafeLogger("Microsoft.DurableTask");
6763
this.deserializedInput = deserializedInput;
6864
}
@@ -85,7 +81,7 @@ public TaskOrchestrationContextWrapper(
8581
/// <summary>
8682
/// Gets the configuration settings for the orchestration.
8783
/// </summary>
88-
public override IDictionary<string, object?> Properties { get; } = new Dictionary<string, object?>();
84+
public override IReadOnlyDictionary<string, object?> Properties { get; } = new Dictionary<string, object?>();
8985

9086
/// <inheritdoc/>
9187
public override TaskOrchestrationEntityFeature Entities

0 commit comments

Comments
 (0)