param

Author: YunchuWang

src/ScheduledTasks/Entity/Schedule.cs

@@ -352,7 +352,7 @@ public void RunSchedule(TaskEntityContext context, string executionToken)
 
     static DateTimeOffset? ComputeInitialRunTime(ScheduleConfiguration scheduleConfig)
     {
-        if (scheduleConfig.StartImmediatelyIfLate == true &&
+        if (scheduleConfig.StartImmediatelyIfLate &&
             scheduleConfig.StartAt.HasValue &&
             DateTimeOffset.UtcNow > scheduleConfig.StartAt.Value)
         {

src/ScheduledTasks/Models/ScheduleConfiguration.cs

@@ -87,9 +87,9 @@ public TimeSpan? Interval
     }
 
     /// <summary>
-    /// Gets or sets whether the schedule should start immediately if it's late.
+    /// Gets or sets a value indicating whether gets or sets whether the schedule should start immediately if it's late.
     /// </summary>
-    public bool? StartImmediatelyIfLate { get; set; } = false;
+    public bool StartImmediatelyIfLate { get; set; }
 
     /// <summary>
     /// Creates a new configuration from the provided creation options.
@@ -125,7 +125,7 @@ public HashSet<string> Update(ScheduleUpdateOptions updateOptions)
             updatedFields.Add(nameof(this.OrchestrationName));
         }
 
-        if (updateOptions.OrchestrationInput == null)
+        if (!string.IsNullOrEmpty(updateOptions.OrchestrationInput))
         {
             this.OrchestrationInput = updateOptions.OrchestrationInput;
             updatedFields.Add(nameof(this.OrchestrationInput));

src/ScheduledTasks/Models/ScheduleCreationOptions.cs

@@ -11,7 +11,7 @@ public record ScheduleCreationOptions
     /// <summary>
     /// The interval of the schedule.
     /// </summary>
-    TimeSpan? interval;
+    TimeSpan interval;
 
     string orchestrationName = string.Empty;
 
@@ -27,7 +27,7 @@ public string OrchestrationName
     /// <summary>
     /// Gets the ID of the schedule, if not provided, default to a new GUID.
     /// </summary>
-    public string ScheduleId { get; init; } = Guid.NewGuid().ToString("N");
+    public string ScheduleId { get; init; };
 
     /// <summary>
     /// Gets the input to the orchestration function.
@@ -52,22 +52,19 @@ public string OrchestrationName
     /// <summary>
     /// Gets the interval of the schedule.
     /// </summary>
-    public TimeSpan? Interval
+    public TimeSpan Interval
     {
         get => this.interval;
         init
         {
-            if (value.HasValue)
+            if (value <= TimeSpan.Zero)
             {
-                if (value.Value <= TimeSpan.Zero)
-                {
-                    throw new ArgumentException("Interval must be positive", nameof(value));
-                }
+                throw new ArgumentException("Interval must be positive", nameof(value));
+            }
 
-                if (value.Value.TotalSeconds < 1)
-                {
-                    throw new ArgumentException("Interval must be at least 1 second", nameof(value));
-                }
+            if (value.TotalSeconds < 1)
+            {
+                throw new ArgumentException("Interval must be at least 1 second", nameof(value));
             }
 
             this.interval = value;
@@ -77,5 +74,5 @@ public TimeSpan? Interval
     /// <summary>
     /// Gets a value indicating whether to start the schedule immediately if it is late. Default is false.
     /// </summary>
-    public bool? StartImmediatelyIfLate { get; init; } = false;
+    public bool StartImmediatelyIfLate { get; init; }
 }

src/ScheduledTasks/Models/ScheduleUpdateOptions.cs

@@ -61,7 +61,7 @@ public TimeSpan? Interval
     }
 
     /// <summary>
-    /// Gets or initializes whether the schedule should start immediately if it's late. Default is false.
+    /// Gets or initializes whether the schedule should start immediately if it's late.
     /// </summary>
-    public bool? StartImmediatelyIfLate { get; init; } = false;
+    public bool? StartImmediatelyIfLate { get; init; }
 }