Skip to content

Commit df1db68

Browse files
CopilotYunchuWang
andcommitted
Simplify IsILoggerType method per code review feedback
Co-authored-by: YunchuWang <[email protected]>
1 parent 088cc67 commit df1db68

File tree

1 file changed

+1
-12
lines changed

1 file changed

+1
-12
lines changed

src/Analyzers/Orchestration/LoggerOrchestrationAnalyzer.cs

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -128,27 +128,16 @@ bool IsILoggerType(ITypeSymbol type)
128128
return true;
129129
}
130130

131-
// Check if the type is ILogger<T> by checking if it implements ILogger
131+
// Check if the type implements ILogger interface (covers ILogger<T> case)
132132
if (type is INamedTypeSymbol namedType)
133133
{
134-
// Check all interfaces implemented by the type
135134
foreach (INamedTypeSymbol interfaceType in namedType.AllInterfaces)
136135
{
137136
if (SymbolEqualityComparer.Default.Equals(interfaceType, this.iLoggerSymbol))
138137
{
139138
return true;
140139
}
141140
}
142-
143-
// Also check if the original definition matches (for generic types like ILogger<T>)
144-
INamedTypeSymbol originalDefinition = namedType.OriginalDefinition;
145-
foreach (INamedTypeSymbol interfaceType in originalDefinition.AllInterfaces)
146-
{
147-
if (SymbolEqualityComparer.Default.Equals(interfaceType, this.iLoggerSymbol))
148-
{
149-
return true;
150-
}
151-
}
152141
}
153142

154143
return false;

0 commit comments

Comments
 (0)