fix tests

Author: YunchuWang

src/ScheduledTasks/Entity/Schedule.cs

@@ -282,17 +282,25 @@ DateTimeOffset DetermineNextRunTime(ScheduleConfiguration scheduleConfig)
         // compute time gap between now and startat if set else with ScheduleCreatedAt
         TimeSpan timeSinceStart = now - startTime;
 
-        if (timeSinceStart <= TimeSpan.Zero && scheduleConfig.StartImmediatelyIfLate)
+        // timeSinceStart is negative that means next run time should be in future
+        if (timeSinceStart < TimeSpan.Zero)
         {
-            return now;
+            return startTime;
         }
-        else
-        {
-            // Calculate number of intervals between start time and now
-            int intervalsElapsed = (int)(timeSinceStart.Ticks / scheduleConfig.Interval.Ticks);
 
-            // Compute next run time based on intervals elapsed since start
-            return startTime + TimeSpan.FromTicks(scheduleConfig.Interval.Ticks * (intervalsElapsed + 1));
+        // timeSinceStart is >= 0, this mean current time already past start time
+        bool isFirstRun = this.State.LastRunAt == null;
+
+        // check edge case: if this is first run and startimmediatelyiflate is true, run immediately
+        if (isFirstRun && scheduleConfig.StartImmediatelyIfLate)
+        {
+            return now;
         }
+
+        // Calculate number of intervals between start time and now
+        int intervalsElapsed = (int)(timeSinceStart.Ticks / scheduleConfig.Interval.Ticks);
+
+        // Compute next run time based on intervals elapsed since start
+        return startTime + TimeSpan.FromTicks(scheduleConfig.Interval.Ticks * (intervalsElapsed + 1));
     }
 }

test/ScheduledTasks.Tests/Client/ScheduleClientImplTests.cs

@@ -14,25 +14,25 @@ public class ScheduleClientImplTests
 {
     readonly Mock<DurableTaskClient> durableTaskClient;
     readonly Mock<DurableEntityClient> entityClient;
-    readonly Mock<ILogger> logger;
+    readonly ILogger logger;
     readonly ScheduleClientImpl client;
     readonly string scheduleId = "test-schedule";
 
     public ScheduleClientImplTests()
     {
         this.durableTaskClient = new Mock<DurableTaskClient>("test", MockBehavior.Strict);
         this.entityClient = new Mock<DurableEntityClient>("test", MockBehavior.Strict);
-        this.logger = new Mock<ILogger>(MockBehavior.Loose);
+        this.logger = new TestLogger();
         this.durableTaskClient.Setup(x => x.Entities).Returns(this.entityClient.Object);
-        this.client = new ScheduleClientImpl(this.durableTaskClient.Object, this.scheduleId, this.logger.Object);
+        this.client = new ScheduleClientImpl(this.durableTaskClient.Object, this.scheduleId, this.logger);
     }
 
     [Fact]
     public void Constructor_WithNullClient_ThrowsArgumentNullException()
     {
         // Act & Assert
-        var ex = Assert.Throws<ArgumentNullException>(() =>
-            new ScheduleClientImpl(null!, this.scheduleId, this.logger.Object));
+        ArgumentNullException ex = Assert.Throws<ArgumentNullException>(() =>
+            new ScheduleClientImpl(null!, this.scheduleId, this.logger));
         Assert.Equal("client", ex.ParamName);
     }
 
@@ -43,7 +43,7 @@ public void Constructor_WithInvalidScheduleId_ThrowsArgumentException(string inv
     {
         // Act & Assert
         var ex = Assert.Throws<ArgumentException>(() =>
-            new ScheduleClientImpl(this.durableTaskClient.Object, invalidScheduleId, this.logger.Object));
+            new ScheduleClientImpl(this.durableTaskClient.Object, invalidScheduleId, this.logger));
         Assert.Contains("scheduleId cannot be null or empty", ex.Message, StringComparison.OrdinalIgnoreCase);
     }