Skip to content

Commit f29b505

Browse files
CopilotYunchuWang
andcommitted
Combine nested if statements in LoggerOrchestrationAnalyzer
Co-authored-by: YunchuWang <[email protected]>
1 parent 71d8fa7 commit f29b505

File tree

1 file changed

+4
-7
lines changed

1 file changed

+4
-7
lines changed

src/Analyzers/Orchestration/LoggerOrchestrationAnalyzer.cs

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -68,15 +68,12 @@ protected override void VisitMethod(SemanticModel semanticModel, SyntaxNode meth
6868
// Check for ILogger parameters in the method signature
6969
foreach (IParameterSymbol parameter in methodSymbol.Parameters)
7070
{
71-
if (this.IsILoggerType(parameter.Type))
71+
if (this.IsILoggerType(parameter.Type) && parameter.DeclaringSyntaxReferences.Length > 0)
7272
{
7373
// Found an ILogger parameter - report diagnostic at the parameter location
74-
if (parameter.DeclaringSyntaxReferences.Length > 0)
75-
{
76-
SyntaxNode parameterSyntax = parameter.DeclaringSyntaxReferences[0].GetSyntax();
77-
reportDiagnostic(RoslynExtensions.BuildDiagnostic(Rule, parameterSyntax, methodSymbol.Name, orchestrationName));
78-
reportedParameters.Add(parameter);
79-
}
74+
SyntaxNode parameterSyntax = parameter.DeclaringSyntaxReferences[0].GetSyntax();
75+
reportDiagnostic(RoslynExtensions.BuildDiagnostic(Rule, parameterSyntax, methodSymbol.Name, orchestrationName));
76+
reportedParameters.Add(parameter);
8077
}
8178
}
8279

0 commit comments

Comments
 (0)