Change user-agent header to x-user-agent #422
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgillum
reviewed
May 6, 2025
CHANGELOG.md
Outdated
|
|
||
| - Add New Property Properties to TaskOrchestrationContext by @nytian in [#415](https://github.com/microsoft/durabletask-dotnet/pull/415) | ||
| - Add automatic retry on gateway timeout in `GrpcDurableTaskClient.WaitForInstanceCompletionAsync` in [#412](https://github.com/microsoft/durabletask-dotnet/pull/412)) | ||
| - Change user-agent header to x-user-agent ([#422](https://github.com/microsoft/durabletask-dotnet/pull/422)) |
Member
There was a problem hiding this comment.
Rather than writing a new entry, replace or update the one below on line 9 (PR 417).
CHANGELOG.md
Outdated
| ### Microsoft.DurableTask.Client | ||
|
|
||
| - Fix filter not being passed along in `PurgeAllInstancesAsync` (https://github.com/microsoft/durabletask-dotnet/pull/289) | ||
| - Fix filter not being passed along in `PurgeAllInstancesAsync` (<https://github.com/microsoft/durabletask-dotnet/pull/289>) |
Member
There was a problem hiding this comment.
Why are all these lines being changed? Was this intentional or can it be reverted?
Member
Author
There was a problem hiding this comment.
Yeah. It's weird copilot edits. I'll revert
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the user-agent header to x-user-agent to enable consistent SDK user-agent logging across all languages. The change ensures uniformity in header naming for all SDK parity.