Disable breaking 1es spotbug task and manage it directly in ci (#209)

Author: YunchuWang

.github/workflows/build-validation.yml

@@ -44,6 +44,17 @@ jobs:
     - name: Build with Gradle
       run: ./gradlew build -x test
 
+    - name: Run SpotBugs
+      run: ./gradlew spotbugsMain spotbugsTest
+      continue-on-error: false
+      
+    - name: Upload SpotBugs reports
+      uses: actions/upload-artifact@v4
+      with:
+        name: SpotBugs Reports
+        path: '**/build/reports/spotbugs'
+        if-no-files-found: ignore
+    
     - name: Run Unit Tests with Gradle
       run: |
         export JAVA_HOME=$JDK_11

azurefunctions/build.gradle

@@ -2,6 +2,7 @@ plugins {
     id 'java-library'
     id 'maven-publish'
     id 'signing'
+    id 'com.github.spotbugs' version '5.2.1'
 }
 
 group 'com.microsoft'
@@ -85,3 +86,35 @@ java {
     withSourcesJar()
     withJavadocJar()
 }
+
+spotbugs {
+    toolVersion = '4.9.2'
+    effort = 'max'
+    reportLevel = 'high'
+    ignoreFailures = true
+    excludeFilter = file('spotbugs-exclude.xml')
+}
+
+spotbugsMain {
+    reports {
+        html {
+            required = true
+            stylesheet = 'fancy-hist.xsl'
+        }
+        xml {
+            required = true
+        }
+    }
+}
+
+spotbugsTest {
+    reports {
+        html {
+            required = true
+            stylesheet = 'fancy-hist.xsl'
+        }
+        xml {
+            required = true
+        }
+    }
+}

azurefunctions/spotbugs-exclude.xml

@@ -0,0 +1,17 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<FindBugsFilter>
+    <!-- Exclude test classes -->
+    <Match>
+        <Class name="~.*Test"/>
+    </Match>
+    
+    <!-- Exclude common false positives -->
+    <Match>
+        <BugPattern name="DM_CONVERT_CASE"/>
+    </Match>
+    
+    <!-- Exclude serialization related warnings -->
+    <Match>
+        <BugPattern name="SE_NO_SERIALVERSIONID"/>
+    </Match>
+</FindBugsFilter> 

azuremanaged/build.gradle

@@ -12,6 +12,7 @@ plugins {
     id 'idea'
     id 'maven-publish'
     id 'signing'
+    id 'com.github.spotbugs' version '5.2.1'
 }
 
 archivesBaseName = 'durabletask-azuremanaged'
@@ -114,3 +115,35 @@ java {
     withJavadocJar()
 }
 
+spotbugs {
+    toolVersion = '4.9.2'
+    effort = 'max'
+    reportLevel = 'high'
+    ignoreFailures = true
+    excludeFilter = file('spotbugs-exclude.xml')
+}
+
+spotbugsMain {
+    reports {
+        html {
+            required = true
+            stylesheet = 'fancy-hist.xsl'
+        }
+        xml {
+            required = true
+        }
+    }
+}
+
+spotbugsTest {
+    reports {
+        html {
+            required = true
+            stylesheet = 'fancy-hist.xsl'
+        }
+        xml {
+            required = true
+        }
+    }
+}
+

azuremanaged/spotbugs-exclude.xml

@@ -0,0 +1,17 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<FindBugsFilter>
+    <!-- Exclude test classes -->
+    <Match>
+        <Class name="~.*Test"/>
+    </Match>
+    
+    <!-- Exclude common false positives -->
+    <Match>
+        <BugPattern name="DM_CONVERT_CASE"/>
+    </Match>
+    
+    <!-- Exclude serialization related warnings -->
+    <Match>
+        <BugPattern name="SE_NO_SERIALVERSIONID"/>
+    </Match>
+</FindBugsFilter> 

client/build.gradle

@@ -5,6 +5,7 @@ plugins {
     id 'idea'
     id 'maven-publish'
     id 'signing'
+    id 'com.github.spotbugs' version '5.2.1'
 }
 
 group 'com.microsoft'
@@ -180,4 +181,36 @@ publishing {
 java {
     withSourcesJar()
     withJavadocJar()
+}
+
+spotbugs {
+    toolVersion = '4.9.2'
+    effort = 'max'
+    reportLevel = 'high'
+    ignoreFailures = true
+    excludeFilter = file('spotbugs-exclude.xml')
+}
+
+spotbugsMain {
+    reports {
+        html {
+            required = true
+            stylesheet = 'fancy-hist.xsl'
+        }
+        xml {
+            required = true
+        }
+    }
+}
+
+spotbugsTest {
+    reports {
+        html {
+            required = true
+            stylesheet = 'fancy-hist.xsl'
+        }
+        xml {
+            required = true
+        }
+    }
 }

client/spotbugs-exclude.xml

@@ -0,0 +1,22 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<FindBugsFilter>
+    <!-- Exclude generated protobuf code -->
+    <Match>
+        <Package name="com.microsoft.durabletask.protobuf"/>
+    </Match>
+    
+    <!-- Exclude test classes -->
+    <Match>
+        <Class name="~.*Test"/>
+    </Match>
+    
+    <!-- Exclude common false positives -->
+    <Match>
+        <BugPattern name="DM_CONVERT_CASE"/>
+    </Match>
+    
+    <!-- Exclude serialization related warnings -->
+    <Match>
+        <BugPattern name="SE_NO_SERIALVERSIONID"/>
+    </Match>
+</FindBugsFilter> 

eng/ci/official-build.yml

@@ -28,7 +28,9 @@ extends:
             name: 1es-pool-azfunc
             image: 1es-windows-2022
             os: windows
-
+        sdl:
+          spotBugs:
+            enabled: false
         stages:
             - stage: BuildAndSign
               dependsOn: []

internal/durabletask-protobuf/PROTO_SOURCE_COMMIT_HASH

@@ -1 +1 @@
-b1e9c96572a9fa0b81829fe0e976cd39de91877e
+c85ef11430ff8e10e21105abb545b0803bb86c66

internal/durabletask-protobuf/protos/orchestrator_service.proto

@@ -463,6 +463,7 @@ message PurgeInstanceFilter {
 
 message PurgeInstancesResponse {
     int32 deletedInstanceCount = 1;
+    google.protobuf.BoolValue isComplete = 2;
 }
 
 message CreateTaskHubRequest {