Skip to content

Commit 7cda76c

Browse files
committed
Adressing review feedback
Signed-off-by: Ryan Lettieri <[email protected]>
1 parent aa1a8aa commit 7cda76c

File tree

3 files changed

+10
-12
lines changed

3 files changed

+10
-12
lines changed

.github/workflows/pr-validation.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ jobs:
3737
pip install -r requirements.txt
3838
- name: Lint with flake8
3939
run: |
40-
flake8 . --count --show-source --statistics --exit-zero
40+
flake8 . --count --show-source --statistics
4141
- name: Pytest unit tests
4242
working-directory: tests/durabletask
4343
run: |

.github/workflows/publish-dts-sdk.yml

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,11 @@ on:
55
tags:
66
- 'azuremanaged-v*' # Only run for tags starting with "azuremanaged-v"
77

8-
# on:
9-
# push:
10-
# branches: [ "main" ]
11-
# pull_request:
12-
# branches: [ "main" ]
13-
8+
on:
9+
push:
10+
branches: [ "main" ]
11+
pull_request:
12+
branches: [ "main" ]
1413

1514
jobs:
1615
lint:
@@ -31,20 +30,21 @@ jobs:
3130
working-directory: durabletask-azuremanaged
3231
run: flake8 .
3332

34-
3533
run-docker-tests:
34+
env:
35+
EMULATOR_VERSION: "v0.0.4" # Define the variable
3636
needs: lint
3737
runs-on: ubuntu-latest
3838
steps:
3939
- name: Checkout repository
4040
uses: actions/checkout@v4
4141

4242
- name: Pull Docker image
43-
run: docker pull mcr.microsoft.com/dts/dts-emulator:v0.0.4
43+
run: docker pull mcr.microsoft.com/dts/dts-emulator:$EMULATOR_VERSION
4444

4545
- name: Run Docker container
4646
run: |
47-
docker run --name dtsemulator -d -p 8080:8080 mcr.microsoft.com/dts/dts-emulator:v0.0.4
47+
docker run --name dtsemulator -d -p 8080:8080 mcr.microsoft.com/dts/dts-emulator:$EMULATOR_VERSION
4848
4949
- name: Wait for container to be ready
5050
run: sleep 10 # Adjust if your service needs more time to start

examples/dts/requirements.txt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
autopep8
22
grpcio>=1.60.0 # 1.60.0 is the version introducing protobuf 1.25.X support, newer versions are backwards compatible
33
protobuf
4-
pytest
5-
pytest-cov
64
azure-identity
75
durabletask-azuremanaged
86
durabletask

0 commit comments

Comments
 (0)