Skip to content

Commit a993cfc

Browse files
committed
Remove resolved todos
1 parent ebf98bf commit a993cfc

File tree

2 files changed

+0
-3
lines changed

2 files changed

+0
-3
lines changed

durabletask/entities/entity_lock.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ def __enter__(self):
99
return self
1010

1111
def __exit__(self, exc_type, exc_val, exc_tb): # TODO: Handle exceptions?
12-
print(f"Unlocking entities: {self._context._entity_context.critical_section_locks}")
1312
for entity_unlock_message in self._context._entity_context.emit_lock_release_messages():
1413
task_id = self._context.next_sequence_number()
1514
action = pb.OrchestratorAction(id=task_id, sendEntityMessage=entity_unlock_message)

durabletask/internal/orchestration_entity_context.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,6 @@ def emit_lock_release_messages(self):
6767
))
6868
yield unlock_event
6969

70-
# TODO: Emit the actual release messages (?)
7170
self.critical_section_locks = []
7271
self.available_locks = []
7372
self.critical_section_id = None
@@ -104,7 +103,6 @@ def emit_acquire_message(self, critical_section_id: str, entities: List[EntityIn
104103
return request, target
105104

106105
def complete_acquire(self, critical_section_id):
107-
# TODO: HashSet or equivalent
108106
if self.critical_section_id != critical_section_id:
109107
raise RuntimeError(f"Unexpected lock acquire for critical section ID '{critical_section_id}' (expected '{self.critical_section_id}')")
110108
self.available_locks = self.critical_section_locks

0 commit comments

Comments
 (0)